Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424342AbcKANfz (ORCPT ); Tue, 1 Nov 2016 09:35:55 -0400 Received: from mail-lf0-f52.google.com ([209.85.215.52]:36020 "EHLO mail-lf0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424307AbcKANfx (ORCPT ); Tue, 1 Nov 2016 09:35:53 -0400 Subject: Re: [PATCH v4 20/23] ARM: shmobile: rcar-gen2: Stop passing mode pins state to clock driver To: Geert Uytterhoeven , Philipp Zabel , Michael Turquette , Stephen Boyd , Simon Horman , Magnus Damm References: <1477055857-17936-1-git-send-email-geert+renesas@glider.be> <1477055857-17936-21-git-send-email-geert+renesas@glider.be> Cc: devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <722d91fe-574a-8613-34ff-d44be19157be@cogentembedded.com> Date: Tue, 1 Nov 2016 16:35:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1477055857-17936-21-git-send-email-geert+renesas@glider.be> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1333 Lines: 42 On 10/21/2016 04:17 PM, Geert Uytterhoeven wrote: > Now the R-Car Gen2 CPG clock driver obtains the state of the mode pins > from the R-Car RST driver, there's no longer a need to pass this state > explicitly. Hence we can just call of_clk_init() instead. > > Signed-off-by: Geert Uytterhoeven > Acked-by: Dirk Behme > --- > v4: > - Add Acked-by, > - Rebase on top of "ARM: shmobile: rcar-gen2: Obtain extal frequency > from DT", > - Remove the call to rcar_gen2_read_mode_pins(), > > v3: > - Drop "select MFD_SYSCON", as the clock driver no longer uses syscon, > > v2: > - Kill compiler warning if CONFIG_ARM_ARCH_TIMER is not enabled. > --- > arch/arm/mach-shmobile/setup-rcar-gen2.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-shmobile/setup-rcar-gen2.c b/arch/arm/mach-shmobile/setup-rcar-gen2.c > index afb9fdcd3d9084e2..b527258e0a62e806 100644 > --- a/arch/arm/mach-shmobile/setup-rcar-gen2.c > +++ b/arch/arm/mach-shmobile/setup-rcar-gen2.c [...] > @@ -130,7 +129,7 @@ void __init rcar_gen2_timer_init(void) > iounmap(base); > #endif /* CONFIG_ARM_ARCH_TIMER */ > > - rcar_gen2_clocks_init(mode); > + of_clk_init(NULL); > clocksource_probe(); > } > This hunk no longer applies to devel. MBR, Sergei