Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S966031AbcKAOBa (ORCPT <rfc822;w@1wt.eu>);
        Tue, 1 Nov 2016 10:01:30 -0400
Received: from verein.lst.de ([213.95.11.211]:53451 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S965773AbcKAOBa (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 1 Nov 2016 10:01:30 -0400
Date: Tue, 1 Nov 2016 15:01:27 +0100
From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
        Alexander Graf <agraf@suse.com>, Ming@suse.de,
        "Lei <tom.leiming"@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] loop: Add 'lo_logical_blocksize'
Message-ID: <20161101140127.GB16815@lst.de>
References: <1477942639-109971-1-git-send-email-hare@suse.de> <1477942639-109971-4-git-send-email-hare@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1477942639-109971-4-git-send-email-hare@suse.de>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 307
Lines: 7

On Mon, Oct 31, 2016 at 08:37:18PM +0100, Hannes Reinecke wrote:
> Add a new field 'lo_logical_blocksize' to hold the logical
> blocksize of the loop device.

Why do we use the same flag for both block sizes?  If there is a good
reason for that it should be documented and both should be in the same
patch.