Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966396AbcKAOTp (ORCPT ); Tue, 1 Nov 2016 10:19:45 -0400 Received: from verein.lst.de ([213.95.11.211]:53539 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966280AbcKAOSS (ORCPT ); Tue, 1 Nov 2016 10:18:18 -0400 Date: Tue, 1 Nov 2016 15:18:16 +0100 From: Christoph Hellwig To: Omar Sandoval Cc: Christoph Hellwig , axboe@fb.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] block: fast-path for small and simple direct I/O requests Message-ID: <20161101141816.GA17142@lst.de> References: <1477936765-8828-1-git-send-email-hch@lst.de> <1477936765-8828-3-git-send-email-hch@lst.de> <20161031231911.GA20713@vader> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161031231911.GA20713@vader> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 304 Lines: 12 On Mon, Oct 31, 2016 at 04:19:11PM -0700, Omar Sandoval wrote: > > + if (unlikely(ret)) > > + return ret; > > + ret = bio.bi_iter.bi_size; > > + > > + if (iov_iter_rw(iter) == READ) { > > + bio_set_op_attrs(&bio, REQ_OP_READ, 0); > > + if (iter->type == ITER_IOVEC) > > Nit: iter_is_iovec()? Fixed.