Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752479AbcKAPdi (ORCPT ); Tue, 1 Nov 2016 11:33:38 -0400 Received: from smtp.math.uni-bielefeld.de ([129.70.45.10]:50517 "EHLO smtp.math.uni-bielefeld.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752377AbcKAPdO (ORCPT ); Tue, 1 Nov 2016 11:33:14 -0400 Subject: Re: [char-misc:char-misc-testing] warning To: Robin van der Gracht Cc: Sean Paul , Greg Kroah-Hartman , linux-kernel@vger.kernel.org References: <20161101150702.00a6379f@erd979> From: Tobias Jakobi Message-ID: <5818B5AF.5000806@math.uni-bielefeld.de> Date: Tue, 1 Nov 2016 16:33:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40 MIME-Version: 1.0 In-Reply-To: <20161101150702.00a6379f@erd979> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1586 Lines: 54 Hello Robin, I'm afraid I can't help you with that. The series was done as a request by Daniel Vetter, see here for reference: http://www.spinics.net/lists/dri-devel/msg113011.html I don't have any nouveau platform here. With best wishes, Tobias Robin van der Gracht wrote: > Hi Tobias, > > Lately I've submitted patches to Gregs (char-misc) git repo and they got > bounced because the kbuild bot threw a warning: > > warning: (PMAC_BACKLIGHT && DRM_NOUVEAU && HT16K33 && FB_TFT) selects > FB_BACKLIGHT which has unmet direct dependencies (HAS_IOMEM && FB) > > My patched added a new driver named HT16K33, but.. > > I believe the warning is the result of a dependency issue made possible by this commit: > https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/char-misc/+/fc497ed8361f34e465f31e9babcb88efe38fe433 > > The kbuild bots configuration file stated: > CONFIG_HAS_IOMEM=y > CONFIG_DRM_NOUVEAU=y > CONFIG_DRM_NOUVEAU_BACKLIGHT=y > CONFIG_FB_BACKLIGHT=y > # CONFIG_FB is not set > > PMAC_BACKLIGHT, HT16K33 and FB_TFT ware not mentioned in the config file. > I've attached the config file to this email. > > FB_BACKLIGHT depends on FB like so: > > (drivers/video/fbdev/Kconfig) > config FB_BACKLIGHT > bool > depends on FB > ... > > In your commit the 'select FB' is removed from the config DRM_NOUVEAU in > the drivers/gpu/drm/nouveau/Kconfig file but DRM_NOUVEAU still selects > FB_BACKLIGHT when using DRM_NOUVEAU_BACKLIGHT. > > Is no one else selects FB, the warning mentioned above is raised. > > Would you like to verify this? > > Regards, >