Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750960AbcKAPrn (ORCPT ); Tue, 1 Nov 2016 11:47:43 -0400 Received: from mail-yw0-f194.google.com ([209.85.161.194]:33245 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750745AbcKAPrl (ORCPT ); Tue, 1 Nov 2016 11:47:41 -0400 MIME-Version: 1.0 In-Reply-To: <20161101154232.6451-1-emil.l.velikov@gmail.com> References: <20161101154232.6451-1-emil.l.velikov@gmail.com> From: Alex Deucher Date: Tue, 1 Nov 2016 11:47:39 -0400 Message-ID: Subject: Re: [PATCH] PCI: create revision file in sysfs To: Emil Velikov Cc: Maling list - DRI developers , Jammy Zhou , =?UTF-8?Q?Michel_D=C3=A4nzer?= , LKML , Linux PCI , Bjorn Helgaas Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uA1Flmto003472 Content-Length: 1968 Lines: 58 On Tue, Nov 1, 2016 at 11:42 AM, Emil Velikov wrote: > From: Emil Velikov > > Currently the revision isn't available via sysfs/libudev thus if one > wants to know the value they need to read through the config file. > > This in itself wakes/powers up the device, causing unwanted delay > since it can be quite costly. > > Expose the revision as a separate file, just like we do for the device, > vendor, their subsystem version and class. > > Cc: Jammy Zhou > Cc: Michel Dänzer > Cc: Bjorn Helgaas > Cc: linux-pci@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Emil Velikov Reviewed-by: Alex Deucher > --- > Gents, I'm not subscribed to the mailing list so please keep me in the > CC chain. > > Thanks > Emil > --- > drivers/pci/pci-sysfs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c > index bcd10c7..0666287 100644 > --- a/drivers/pci/pci-sysfs.c > +++ b/drivers/pci/pci-sysfs.c > @@ -50,6 +50,7 @@ pci_config_attr(vendor, "0x%04x\n"); > pci_config_attr(device, "0x%04x\n"); > pci_config_attr(subsystem_vendor, "0x%04x\n"); > pci_config_attr(subsystem_device, "0x%04x\n"); > +pci_config_attr(revision, "0x%02x\n"); > pci_config_attr(class, "0x%06x\n"); > pci_config_attr(irq, "%u\n"); > > @@ -568,6 +569,7 @@ static struct attribute *pci_dev_attrs[] = { > &dev_attr_device.attr, > &dev_attr_subsystem_vendor.attr, > &dev_attr_subsystem_device.attr, > + &dev_attr_revision.attr, > &dev_attr_class.attr, > &dev_attr_irq.attr, > &dev_attr_local_cpus.attr, > -- > 2.9.3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel