Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753379AbcKAQ7p (ORCPT ); Tue, 1 Nov 2016 12:59:45 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:41821 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753288AbcKAQ7m (ORCPT ); Tue, 1 Nov 2016 12:59:42 -0400 X-ME-Sender: X-Sasl-enc: 1U6AtYhQxYfCTPAwHxMc5+fVrR3xlNRi/ra1fcu8nYj1 1478019581 Subject: Re: [PATCH net-next 5/5] ipv6: Compute multipath hash for forwarded ICMP errors from offending packet To: David Miller References: <87bmxznsgg.fsf@redhat.com> <20161101.113505.1429989348222226550.davem@davemloft.net> <7f83a405-0520-a3ed-fc21-402d702483f9@stressinduktion.org> <20161101.123904.1432761986039949225.davem@davemloft.net> Cc: jkbs@redhat.com, tom@herbertland.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net From: Hannes Frederic Sowa Message-ID: Date: Tue, 1 Nov 2016 17:59:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161101.123904.1432761986039949225.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 24 On 01.11.2016 17:39, David Miller wrote: > From: Hannes Frederic Sowa > Date: Tue, 1 Nov 2016 17:27:56 +0100 > >> On 01.11.2016 16:35, David Miller wrote: >>> I have a really hard time accepting a "fix" that depends upon behavior >>> that the Linux ipv6 stack doesn't even have. >> >> We actually support this feature: > > But it is forbidden when the sysctl I mentioned is set, which is the > default. > > I'm talking about default behavior, which is to not reflect. Oh, yes, understood. I think we can flip this sysctl by default to off: current default kernel config actually generates flow labels on its own, so the description of this sysctl is violated by default anyway, as it doesn't preserve the uniqueness anymore. Bye, Hannes