Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753843AbcKARq2 (ORCPT ); Tue, 1 Nov 2016 13:46:28 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:36883 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753786AbcKARqZ (ORCPT ); Tue, 1 Nov 2016 13:46:25 -0400 MIME-Version: 1.0 In-Reply-To: <564faf01-f4d7-4bdb-ee48-76a893d3d4c0@codeaurora.org> References: <1477429046-26855-1-git-send-email-spjoshi@codeaurora.org> <20161101000555.GK25787@tuxbot> <564faf01-f4d7-4bdb-ee48-76a893d3d4c0@codeaurora.org> From: Bjorn Andersson Date: Tue, 1 Nov 2016 10:46:23 -0700 Message-ID: Subject: Re: [PATCH v2 1/1] remoteproc: Add support for xo clock To: Stephen Boyd Cc: Sarangdhar Joshi , Ohad Ben-Cohen , linux-remoteproc@vger.kernel.org, lkml , linux-arm-msm , Trilok Soni Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 970 Lines: 25 On Tue, Nov 1, 2016 at 10:41 AM, Stephen Boyd wrote: > On 10/31/2016 05:05 PM, Bjorn Andersson wrote: >> On Tue 25 Oct 13:57 PDT 2016, Sarangdhar Joshi wrote: >> >>> Add xo clock support required to boot up Qualcomm ADSP processor. >>> The ADSP remoteproc driver keeps xo clock enabled until the >>> driver receives "handover" irq, in order to allow ADSP processor >>> to vote for xo clock with rpm. >> Looks good, thanks. >> >> We have to add the clock to the DT binding and run that by Rob again, >> before merging the driver and this patch. >> > > Maybe we should make the xo clock required. We always have a clock for > it somewhere, either RPM controlled or as a fixed rate clock so it > should work just as well. > As far as I can see it is required, after Sarangdhar's patch - so this is what I meant we need to add to the DT binding before merging that. And as you say, we can always make it reference "xo_board" for now. Regards, Bjorn