Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754074AbcKARxf (ORCPT ); Tue, 1 Nov 2016 13:53:35 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:32889 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753783AbcKARxc (ORCPT ); Tue, 1 Nov 2016 13:53:32 -0400 Subject: Re: [PATCH] sound: soc: cygnus: add depends on HAS_DMA To: Ray Jui , Jaroslav Kysela , Takashi Iwai References: <1475868258-10689-1-git-send-email-scott.branden@broadcom.com> Cc: Liam Girdwood , Mark Brown , BCM Kernel Feedback , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org From: Scott Branden Message-ID: <5feb3eea-ba7c-93b7-2708-f0c68c215a17@broadcom.com> Date: Tue, 1 Nov 2016 10:53:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1086 Lines: 36 Hi Takashi/Jaroslav, Could you pick up this patch? On 16-10-08 01:26 PM, Ray Jui wrote: > Hi Scott, > > On 10/7/2016 12:24 PM, Scott Branden wrote: >> add depends on HAS_DMA to Kconfig. This fixes error reported >> by kbuild test robot when building for ARCH=m32r: >> ERROR: "bad_dma_ops" [sound/soc/bcm/snd-soc-cygnus.ko] undefined! >> >> Signed-off-by: Scott Branden >> --- >> sound/soc/bcm/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/sound/soc/bcm/Kconfig b/sound/soc/bcm/Kconfig >> index d528aac..edf3671 100644 >> --- a/sound/soc/bcm/Kconfig >> +++ b/sound/soc/bcm/Kconfig >> @@ -11,6 +11,7 @@ config SND_BCM2835_SOC_I2S >> config SND_SOC_CYGNUS >> tristate "SoC platform audio for Broadcom Cygnus chips" >> depends on ARCH_BCM_CYGNUS || COMPILE_TEST >> + depends on HAS_DMA >> help >> Say Y if you want to add support for ASoC audio on Broadcom >> Cygnus chips (bcm958300, bcm958305, bcm911360) > Looks good to me. > > Reviewed-by: Ray Jui > Thanks, Scott