Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754173AbcKARyn (ORCPT ); Tue, 1 Nov 2016 13:54:43 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:34732 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754141AbcKARyk (ORCPT ); Tue, 1 Nov 2016 13:54:40 -0400 From: Jens Axboe X-Google-Original-From: Jens Axboe Date: Tue, 1 Nov 2016 11:54:37 -0600 To: Christoph Hellwig Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: block device direct I/O fast path Message-ID: <20161101175437.GC9797@kernel.dk> References: <1477936765-8828-1-git-send-email-hch@lst.de> <20161101170019.GB9797@kernel.dk> <20161101170636.GA22639@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161101170636.GA22639@lst.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 24 On Tue, Nov 01 2016, Christoph Hellwig wrote: > On Tue, Nov 01, 2016 at 11:00:19AM -0600, Jens Axboe wrote: > > #2 is a bit more problematic, I'm pondering how we can implement that on > > top of the bio approach. The nice thing about the request based approach > > is that we have a 1:1 mapping with the unit on the driver side. And we > > have a place to store the timer. I don't particularly love the embedded > > timer, however, it'd be great to implement that differently. Trying to > > think of options there, haven't found any yet. > > I have a couple ideas for that. Give me a few weeks and I'll send > patches. I'm not that patient :-) For the SYNC part, it should be easy enough to do by just using an on-stack hrtimer. I guess that will do for now, since we don't have poll support for async O_DIRECT right now anyway. http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.10/dio&id=e96d9afd56791a61d463cb88f8f3b48393b71020 Untested, but should get the point across. I'll fire up a test box. -- Jens Axboe