Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753482AbcKASMz (ORCPT ); Tue, 1 Nov 2016 14:12:55 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:49450 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751757AbcKASMy (ORCPT ); Tue, 1 Nov 2016 14:12:54 -0400 Date: Tue, 01 Nov 2016 14:12:49 -0400 (EDT) Message-Id: <20161101.141249.1579276311119537608.davem@davemloft.net> To: matanb@mellanox.com Cc: christophe.jaillet@wanadoo.fr, leonro@mellanox.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] net/mlx5: Simplify a test From: David Miller In-Reply-To: <025cb4e1-f5e8-8bc9-0d4f-3ee8f8d1bb5d@mellanox.com> References: <20161101071053.12486-1-christophe.jaillet@wanadoo.fr> <025cb4e1-f5e8-8bc9-0d4f-3ee8f8d1bb5d@mellanox.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 01 Nov 2016 10:13:19 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1125 Lines: 35 From: Matan Barak Date: Tue, 1 Nov 2016 11:38:18 +0200 > On 01/11/2016 09:10, Christophe JAILLET wrote: >> 'create_root_ns()' does not return an error pointer, so the test can >> be >> simplified to be more consistent. >> >> Signed-off-by: Christophe JAILLET >> --- >> drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c >> b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c >> index 904853f9cf7a..330955f6badc 100644 >> --- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c >> +++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c >> @@ -1833,7 +1833,7 @@ static int init_root_ns(struct >> mlx5_flow_steering *steering) >> { >> >> steering->root_ns = create_root_ns(steering, FS_FT_NIC_RX); >> - if (IS_ERR_OR_NULL(steering->root_ns)) >> + if (!steering->root_ns) >> goto cleanup; >> >> if (init_root_tree(steering, &root_fs, &steering->root_ns->ns.node)) >> > > Thanks. > Acked-by: Matan Barak > Applied.