Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753983AbcKASqs (ORCPT ); Tue, 1 Nov 2016 14:46:48 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:60218 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751845AbcKASqq (ORCPT ); Tue, 1 Nov 2016 14:46:46 -0400 Date: Tue, 1 Nov 2016 19:46:39 +0100 From: Andrew Lunn To: Jon Mason Cc: David Miller , Rob Herring , Mark Rutland , Florian Fainelli , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, rafal@milecki.pl, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 2/6] net: phy: broadcom: Add BCM54810 PHY entry Message-ID: <20161101184639.GI10785@lunn.ch> References: <1478022694-25308-1-git-send-email-jon.mason@broadcom.com> <1478022694-25308-3-git-send-email-jon.mason@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478022694-25308-3-git-send-email-jon.mason@broadcom.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 276 Lines: 12 Hi Jon > @@ -56,6 +57,8 @@ > #define PHY_BRCM_EXT_IBND_TX_ENABLE 0x00002000 > #define PHY_BRCM_CLEAR_RGMII_MODE 0x00004000 > #define PHY_BRCM_DIS_TXCRXC_NOENRGY 0x00008000 > +#define PHY_BRCM_EXP_LANE_SWAP 0x00010000 > + You define this, but don't use it... Andrew