Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754693AbcKAT6y (ORCPT ); Tue, 1 Nov 2016 15:58:54 -0400 Received: from www381.your-server.de ([78.46.137.84]:49554 "EHLO www381.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754653AbcKAT6u (ORCPT ); Tue, 1 Nov 2016 15:58:50 -0400 Subject: Re: [PATCH 1/6] staging: iio: set proper supply name to devm_regulator_get() To: Matt Ranostay , Eva Rachel Retuya References: <1477933475-21914-1-git-send-email-eraretuya@gmail.com> <1477933475-21914-2-git-send-email-eraretuya@gmail.com> Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, Linux Kernel , Michael.Hennerich@analog.com, Jonathan Cameron , knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org From: Lars-Peter Clausen Message-ID: <73bc1e52-d728-a61b-69f3-a567c0b05e28@metafoo.de> Date: Tue, 1 Nov 2016 20:58:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Authenticated-Sender: lars@metafoo.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 780 Lines: 18 On 11/01/2016 05:03 AM, Matt Ranostay wrote: > On Mon, Oct 31, 2016 at 10:04 AM, Eva Rachel Retuya wrote: >> The name passed to devm_regulator_get() should match the name of the >> supply as specified in the device datasheet. This makes it clear what >> power supply is being referred to in case of presence of other >> regulators. >> >> Currently, the supply name specified on the affected devices is 'vcc'. >> Use lowercase version of the datasheet name to specify the supply >> voltage. >> > > Aren't we possibly breaking current device tree definitions that > people may have? We should still check the old name after the new > datasheet name in my opinion. None of those drivers have DT bindings, so I think we are OK. And they are in staging anyway.