Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754827AbcKAUAV (ORCPT ); Tue, 1 Nov 2016 16:00:21 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:34582 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754497AbcKAT76 (ORCPT ); Tue, 1 Nov 2016 15:59:58 -0400 Date: Tue, 1 Nov 2016 15:59:48 -0400 From: Jon Mason To: Andrew Lunn Cc: David Miller , Rob Herring , Mark Rutland , Florian Fainelli , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, rafal@milecki.pl, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 2/6] net: phy: broadcom: Add BCM54810 PHY entry Message-ID: <20161101195946.GA26962@broadcom.com> References: <1478022694-25308-1-git-send-email-jon.mason@broadcom.com> <1478022694-25308-3-git-send-email-jon.mason@broadcom.com> <20161101184639.GI10785@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161101184639.GI10785@lunn.ch> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 481 Lines: 17 On Tue, Nov 01, 2016 at 07:46:39PM +0100, Andrew Lunn wrote: > Hi Jon > > > @@ -56,6 +57,8 @@ > > #define PHY_BRCM_EXT_IBND_TX_ENABLE 0x00002000 > > #define PHY_BRCM_CLEAR_RGMII_MODE 0x00004000 > > #define PHY_BRCM_DIS_TXCRXC_NOENRGY 0x00008000 > > +#define PHY_BRCM_EXP_LANE_SWAP 0x00010000 > > + > > You define this, but don't use it... Good catch. Cruft from the last patch. I'll sendout a quick v4 to address this and the missing Documentation patch. > > Andrew