MIME-Version: 1.0
In-Reply-To: <874m4942gc.wl%kuninori.morimoto.gx@renesas.com>
References: <1472514096-10915-1-git-send-email-john.stultz@linaro.org>
 <3891360.bEMoZb6Wzz@avalon> <CALAqxLWR_6fmdUA=rjGSsjTbUZ4WEMBNTJVR2WCHTKyrEAzWHA@mail.gmail.com>
 <1728900.jTuP8Bd5Ss@avalon> <874m4942gc.wl%kuninori.morimoto.gx@renesas.com>
From: John Stultz <john.stultz@linaro.org>
Date: Tue, 1 Nov 2016 14:41:15 -0700
Message-ID: <CALAqxLXi8=g0=T_M+puN2+vUWKgcY11BnHEFQf_ahA+cp39bYw@mail.gmail.com>
Subject: Re: [PATCH 0/4 v2] Audio support for adv7511 hdmi bridge
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        lkml <linux-kernel@vger.kernel.org>, David Airlie <airlied@linux.ie>,
        Archit Taneja <architt@codeaurora.org>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>,
        Boris Brezillon <boris.brezillon@free-electrons.com>,
        Andy Green <andy@warmcat.com>, Dave Long <dave.long@linaro.org>,
        Guodong Xu <guodong.xu@linaro.org>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Mark Brown <broonie@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>,
        Jose Abreu <joabreu@synopsys.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1841
Lines: 43

On Tue, Oct 18, 2016 at 5:26 PM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
>> > Here's what I'm using to get it working:
>> > https://git.linaro.org/people/john.stultz/android-dev.git/commitdiff/1024cb4
>> > 85b6f00a7e355ce60425f04a584481148
>>
>> Thank you.
>>
>> We need to standardize DT bindings for HDMI sound output. Morimoto-san, could
>> you have a look at the DT bindings proposal for HDMI sound output with the
>> ADV7511, and comment on whether it matches the approach you've taken for HDMI
>> sound output on R-Car Gen3 ?
>
> Above patch is using normal simple-card style for HDMI sound, but as Laurent
> said we want to use same DT style for HDMI video and sound (= OF graph style).
> Fortunately, I posted patch-set for OF graph support on sound card yesterday.
> Can you check this ?
> http://www.spinics.net/lists/devicetree/msg146131.html
> The points are
>  - sound can use OF graph style DT
>  - sound-card DT is no longer needed
>  - it needs type = "sound" property
>
> patch-set [0/23] is this
> http://www.spinics.net/lists/devicetree/msg146113.html

Thanks for the pointers! If I understand this correctly, the OF graph
simple-card method would replace my current simple-card dts usage for
hikey?   Other then just having another out-of-tree patchset to track,
I don't have any objection to trying to use the OF graph simple-card
method in the hikey dts (though I suspect I'll have to pester you for
help when I give it a shot).

Laurent: So this seems to be mostly just a "which implementation do we
use" question for the hikey dts,  and it seems like the adv7511 audio
driver I'm submitting here has any ties to either the graph or normal
simple card method. Is that correct? Are there any changes to the
adv7511 audio support patch you'd like to see or should I just
resubmit it?

thanks
-john