Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754593AbcKAV4D (ORCPT ); Tue, 1 Nov 2016 17:56:03 -0400 Received: from mail-oi0-f48.google.com ([209.85.218.48]:33473 "EHLO mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750889AbcKAV4C (ORCPT ); Tue, 1 Nov 2016 17:56:02 -0400 MIME-Version: 1.0 In-Reply-To: <20161031024942.4415-1-jh80.chung@samsung.com> References: <20161031024942.4415-1-jh80.chung@samsung.com> From: John Stultz Date: Tue, 1 Nov 2016 14:56:00 -0700 Message-ID: Subject: Re: [PATCH 0/2] mmc: dw_mmc: fix the wrong operation for reset controller To: Jaehoon Chung Cc: linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Ulf Hansson , Rob Herring , Mark Rutland , lkml , Guodong Xu , Leo Yan , Vincent Guittot Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 892 Lines: 23 On Sun, Oct 30, 2016 at 7:49 PM, Jaehoon Chung wrote: > This patch adds the "reset-names" as reset controller for dwmmc controller. > Linaro guys had reported the issue about booting stuck. > > Some SoCs are enabled the CONFIG_RESET_CONTROLLER. > then dwmmc controller are waiting for getting reset controller. > But if doesn't define "resets" property in device-tree, it should be stuck. > > If use the reset-names as reset controller for dwmmc controller, > it's more stable than now. > This commit is related with the below commit. > > Fixes: d6786fefe816 ("mmc: dw_mmc: add reset support to dwmmc host controller") So I wasn't hit by the issue, as I don't tend to boot from SD on my hikey, but I did run these patches and I'm not seeing any issues with my Android environment. So for what its worth: Acked-by: John Stultz thanks -john