Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752374AbcKAXgi (ORCPT ); Tue, 1 Nov 2016 19:36:38 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:34695 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750807AbcKAXgh (ORCPT ); Tue, 1 Nov 2016 19:36:37 -0400 MIME-Version: 1.0 In-Reply-To: <87wpgp13ki.fsf@concordia.ellerman.id.au> References: <20161030214047.25037-1-christophe.jaillet@wanadoo.fr> <87wpgp13ki.fsf@concordia.ellerman.id.au> From: Jim Davis Date: Tue, 1 Nov 2016 16:36:35 -0700 Message-ID: Subject: Re: [PATCH] cxl: Fix error handling To: Michael Ellerman Cc: Christophe JAILLET , imunsie@au1.ibm.com, fbarrat@linux.vnet.ibm.com, kernel-janitors@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1354 Lines: 36 On Sun, Oct 30, 2016 at 10:37 PM, Michael Ellerman wrote: > Christophe JAILLET writes: > >> 'cxl_dev_context_init()' returns an error pointer in case of error, not >> NULL. So test it with IS_ERR. >> >> Signed-off-by: Christophe JAILLET >> --- >> un-compiled because I don't have the required cross build environment. > > Do you run Ubuntu or Fedora? If so it's just a dnf/apt-get away: > > $ sudo dnf install gcc-c++-powerpc64-linux-gnu binutils-powerpc64-linux-gnu gcc-powerpc64-linux-gnu > or > $ sudo apt-get install gcc-powerpc64le-linux-gnu gcc-powerpc-linux-gnu libc-dev-powerpc-cross libc-dev-ppc64el-cross > > More here: > > https://github.com/linuxppc/linux/wiki/Building-powerpc-kernels Cool; the little-endian build worked fine, but jim@krebstar:~/linux-rc$ make ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- vmlinux make: powerpc64-linux-gnu-gcc: Command not found make: powerpc64-linux-gnu-gcc: Command not found scripts/kconfig/conf --silentoldconfig Kconfig make: powerpc64-linux-gnu-gcc: Command not found This is on Ubuntu 16.04; there's a /usr/bin/powerpc64le-linux-gnu-gcc from installing gcc-powerpc64le-linux-gnu, and a /usr/bin/powerpc-linux-gnu-gcc from installing gcc-powerpc-linux-gnu, but no /usr/bin/powerpc64-linux-gnu-gcc. -- Jim