Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755129AbcKBBBa (ORCPT ); Tue, 1 Nov 2016 21:01:30 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:38216 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752299AbcKBBB2 (ORCPT ); Tue, 1 Nov 2016 21:01:28 -0400 From: Vivien Didelot To: Andrew Lunn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 04/11] net: dsa: mv88e6xxx: add port FID accessors In-Reply-To: <20161101093819.GA2802@lunn.ch> References: <20161101032023.32762-1-vivien.didelot@savoirfairelinux.com> <20161101032023.32762-5-vivien.didelot@savoirfairelinux.com> <20161101093819.GA2802@lunn.ch> Date: Wed, 02 Nov 2016 02:01:20 +0100 Message-ID: <87vaw64rvj.fsf@ketchup.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 597 Lines: 24 Hi Andrew, Andrew Lunn writes: >> --- a/drivers/net/dsa/mv88e6xxx/port.c >> +++ b/drivers/net/dsa/mv88e6xxx/port.c >> @@ -61,6 +61,8 @@ int mv88e6xxx_port_set_state(struct mv88e6xxx_chip *chip, int port, u8 state) >> return 0; >> } >> >> +/* Offset 0x05: Port Control 1 */ >> + >> /* Offset 0x06: Port Based VLAN Map */ >> >> int mv88e6xxx_port_set_vlan_map(struct mv88e6xxx_chip *chip, int port, u16 map) > > This comment seems in an odd place. It isn't. Port's default FID uses register 0x05 and I document them above the related functions. Thanks, Vivien