Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755117AbcKBB0I (ORCPT ); Tue, 1 Nov 2016 21:26:08 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45926 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753724AbcKBB0F (ORCPT ); Tue, 1 Nov 2016 21:26:05 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 832D1615DD Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Tue, 1 Nov 2016 18:26:02 -0700 From: Stephen Boyd To: Abhishek Sahu Cc: andy.gross@linaro.org, david.brown@linaro.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, mturquette@baylibre.com, galak@codeaurora.org, pradeepb@codeaurora.org, mmcclint@codeaurora.org, varada@codeaurora.org, sricharan@codeaurora.org, architt@codeaurora.org, ntelkar@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 5/7] clk: qcom: ipq4019: corrected sdcc frequency and parent name Message-ID: <20161102012602.GE16026@codeaurora.org> References: <1474460512-31994-1-git-send-email-absahu@codeaurora.org> <1474460512-31994-6-git-send-email-absahu@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474460512-31994-6-git-send-email-absahu@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1718 Lines: 54 On 09/21, Abhishek Sahu wrote: > 1. The parent for sdcc clock is sdccpll so corrected the same > in its parent map. > 2. The frequency value was wrong so changed to correct > frequency. > > Signed-off-by: Abhishek Sahu > --- > drivers/clk/qcom/gcc-ipq4019.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-ipq4019.c b/drivers/clk/qcom/gcc-ipq4019.c > index 160e0cf..b2decd5 100644 > --- a/drivers/clk/qcom/gcc-ipq4019.c > +++ b/drivers/clk/qcom/gcc-ipq4019.c > @@ -120,7 +120,7 @@ static struct parent_map gcc_xo_sdcc1_500_map[] = { > > static const char * const gcc_xo_sdcc1_500[] = { > "xo", > - "ddrpll", > + "ddrpllsdcc", > "fepll500", > }; > > @@ -540,13 +540,13 @@ static struct clk_branch gcc_gp3_clk = { > }; > > static const struct freq_tbl ftbl_gcc_sdcc1_apps_clk[] = { > - F(144000, P_XO, 1, 3, 240), > - F(400000, P_XO, 1, 1, 0), > - F(20000000, P_FEPLL500, 1, 1, 25), > - F(25000000, P_FEPLL500, 1, 1, 20), > - F(50000000, P_FEPLL500, 1, 1, 10), > - F(100000000, P_FEPLL500, 1, 1, 5), None of these changed? Please leave them alone then. > - F(193000000, P_DDRPLL, 1, 0, 0), > + F(144000, P_XO, 1, 3, 240), > + F(400000, P_XO, 1, 1, 0), > + F(20000000, P_FEPLL500, 1, 1, 25), > + F(25000000, P_FEPLL500, 1, 1, 20), > + F(50000000, P_FEPLL500, 1, 1, 10), > + F(100000000, P_FEPLL500, 1, 1, 5), > + F(190000000, P_DDRPLL, 1, 0, 0), And tab out this one appropriately so that it lines up. Then the diff is very clear. > { } -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project