Message-ID: <1052186678.19726.9.camel@iguana.localdomain>
From: Matt_Domsch@Dell.com
To: greg@kroah.com, mochel@osdl.org
cc: alan@redhat.com, linux-kernel@vger.kernel.org, jgarzik@redhat.com
Subject: Re: [RFC][PATCH] Dynamic PCI Device IDs
Date: Mon, 5 May 2003 21:04:35 -0500
MIME-Version: 1.0
Content-Type: text/plain; 
 charset=iso-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1559
Lines: 51

> I like this patch a _lot_ better, nice job.

Thanks.

>   Only one comment:
> > +        if (error < 0)
> > +                return error;
> > +        return count;
> > +
> > +
> > +     return count;
> > +}
> 
> Oops, lost the tabs at the end of the function :)

Duh.  Good eyes.  Fixed.

> This function will not link up a device to a driver properly within
> the driver core, only with the pci code.  So if you do this, the
> driver core still thinks you have a device that is unbound, right? 
> Also, the symlinks don't get created from the bus to the device I
> think, correct?

I think you're right.

> Unfortunatly, looking at the driver core real quickly, I don't see a
> simple way to kick the probe cycle off again for all pci devices, but
> I'm probably just missing something somewhere...

I think drivers/base/bus.c: driver_attach() is what we want, which will
walk the list of the bus's devices and run bus_match() which is
pci_bus_match() which will scan for us.  Just need to un-static
driver_attach() I expect.  Pat, does this sound right?

If that works, probe_each_pci_dev() can go away.  I'll play with it some
more.

Thanks,
Matt
-- 
Matt Domsch
Sr. Software Engineer, Lead Engineer, Architect
Dell Linux Solutions www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/