Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755386AbcKBHEX (ORCPT ); Wed, 2 Nov 2016 03:04:23 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:36934 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755253AbcKBHEV (ORCPT ); Wed, 2 Nov 2016 03:04:21 -0400 MIME-Version: 1.0 In-Reply-To: References: <1477464964-5960-1-git-send-email-peppe.cavallaro@st.com> <1477464964-5960-3-git-send-email-peppe.cavallaro@st.com> <743ffe4a-2c8f-e5f7-f93c-6be16a8a0350@st.com> From: Rayagond Kokatanur Date: Wed, 2 Nov 2016 12:34:19 +0530 Message-ID: Subject: Re: [PATCH (net.git) 2/3] stmmac: fix PTP support for GMAC4 To: Giuseppe CAVALLARO Cc: netdev , alexandre.torgue@st.com, Richard Cochran , linux-kernel@vger.kernel.org, Seraphin Bonnaffe Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1365 Lines: 63 On Wed, Nov 2, 2016 at 12:04 PM, Giuseppe CAVALLARO wrote: > Hello Rayagond > > if patches are ok, can we consider you Acked-by ? Yes. > > Thx > Peppe > > > On 10/27/2016 12:51 PM, Rayagond Kokatanur wrote: >> >> On Thu, Oct 27, 2016 at 4:02 PM, Giuseppe CAVALLARO >> wrote: >>> >>> Hello Rayagond ! >>> >>> On 10/27/2016 12:25 PM, Rayagond Kokatanur wrote: >>>>> >>>>> >>>>> +static int dwmac4_wrback_get_rx_timestamp_status(void *desc, u32 ats) >>>>>> >>>>>> { >>>>>> struct dma_desc *p = (struct dma_desc *)desc; >>>>>> + int ret = -EINVAL; >>>>>> + >>>>>> + /* Get the status from normal w/b descriptor */ >>>>>> + if (likely(p->des3 & TDES3_RS1V)) { >>>>>> + if (likely(p->des1 & RDES1_TIMESTAMP_AVAILABLE)) { >>>>>> + int i = 0; >>>>>> + >>>>>> + /* Check if timestamp is OK from context >>>>>> descriptor */ >>>>>> + do { >>>>>> + ret = dwmac4_rx_check_timestamp(desc); >>>> >>>> >>>> Here, "desc" is not pointing to next descriptor (ie context >>>> descriptor). Driver should check the context descriptor. >>> >>> >>> >>> you are right and this is done by the caller: stmmac_get_rx_hwtstamp >> >> >> Yes. >> >>> >>> Cheers >>> peppe >>> >> >> >> > -- wwr Rayagond