Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755500AbcKBKeU (ORCPT ); Wed, 2 Nov 2016 06:34:20 -0400 Received: from mga07.intel.com ([134.134.136.100]:34114 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752046AbcKBKeT (ORCPT ); Wed, 2 Nov 2016 06:34:19 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,583,1473145200"; d="scan'208";a="896800628" Date: Wed, 2 Nov 2016 04:34:16 -0600 From: Jarkko Sakkinen To: Juergen Gross Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xen.org, david.vrabel@citrix.com, boris.ostrovsky@oracle.com, peterhuewe@gmx.de, tpmdd@selhorst.net, jgunthorpe@obsidianresearch.com, tpmdd-devel@lists.sourceforge.net Subject: Re: [PATCH 04/12] xen: make use of xenbus_read_unsigned() in xen-tpmfront Message-ID: <20161102103416.ruo6qatr2gwblubp@intel.com> References: <1477932510-28594-1-git-send-email-jgross@suse.com> <1477932510-28594-5-git-send-email-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477932510-28594-5-git-send-email-jgross@suse.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1559 Lines: 50 On Mon, Oct 31, 2016 at 05:48:22PM +0100, Juergen Gross wrote: > Use xenbus_read_unsigned() instead of xenbus_scanf() when possible. > This requires to change the type of one read from int to unsigned, > but this case has been wrong before: negative values are not allowed > for the modified case. > > Cc: peterhuewe@gmx.de > Cc: tpmdd@selhorst.net > Cc: jarkko.sakkinen@linux.intel.com > Cc: jgunthorpe@obsidianresearch.com > Cc: tpmdd-devel@lists.sourceforge.net > > Signed-off-by: Juergen Gross Reviewed-by: Jarkko Sakkinen /Jarkko > --- > drivers/char/tpm/xen-tpmfront.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c > index 62028f4..50072cc 100644 > --- a/drivers/char/tpm/xen-tpmfront.c > +++ b/drivers/char/tpm/xen-tpmfront.c > @@ -337,18 +337,14 @@ static int tpmfront_resume(struct xenbus_device *dev) > static void backend_changed(struct xenbus_device *dev, > enum xenbus_state backend_state) > { > - int val; > - > switch (backend_state) { > case XenbusStateInitialised: > case XenbusStateConnected: > if (dev->state == XenbusStateConnected) > break; > > - if (xenbus_scanf(XBT_NIL, dev->otherend, > - "feature-protocol-v2", "%d", &val) < 0) > - val = 0; > - if (!val) { > + if (!xenbus_read_unsigned(dev->otherend, "feature-protocol-v2", > + 0)) { > xenbus_dev_fatal(dev, -EINVAL, > "vTPM protocol 2 required"); > return; > -- > 2.6.6 >