Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755567AbcKBKyT (ORCPT ); Wed, 2 Nov 2016 06:54:19 -0400 Received: from mail.skyhub.de ([78.46.96.112]:33945 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754014AbcKBKyS (ORCPT ); Wed, 2 Nov 2016 06:54:18 -0400 Date: Wed, 2 Nov 2016 11:54:12 +0100 From: Borislav Petkov To: Aaron Miller Cc: Mauro Carvalho Chehab , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] EDAC: expose per-dimm error counts in sysfs Message-ID: <20161102105412.cwywcucgwrvmniy5@pd.tnic> References: <20161025232551.3270769-1-aaronmiller@fb.com> <20161027213332.581284-1-aaronmiller@fb.com> <20161028130246.xcdzjy4mdrthgzol@pd.tnic> <7EB49132-0CB0-46AE-8F2C-1AF334DE4494@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7EB49132-0CB0-46AE-8F2C-1AF334DE4494@fb.com> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1011 Lines: 35 On Fri, Oct 28, 2016 at 06:13:08PM +0000, Aaron Miller wrote: Please do not top-post. ... > On Thu, Oct 27, 2016 at 02:33:32PM -0700, Aaron Miller wrote: > > The old 'csrowX' sysfs directories had per-csrow error counters, but the > > new 'dimmX' directories do not currently expose error counts. > > > > EDAC already keeps these counts, add them to sysfs so per-dimm counts > > are still available when CONFIG_EDAC_LEGACY_SYSFS=n > > > > Signed-off-by: Aaron Miller > > --- In any case, after looking at Mauro's docs changes: https://lkml.kernel.org/r/cover.1477765574.git.mchehab@s-opensource.com you'd need to add those new sysfs files to the "SYSFS INTERFACE" section of wherever Documentation/edac.txt ends up. I believe it is: Documentation/{edac.txt => admin-guide/ras.rst} I believe the easiest would be if you redo this patch ontop of his changes. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.