Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753437AbcKBNOp (ORCPT <rfc822;w@1wt.eu>);
        Wed, 2 Nov 2016 09:14:45 -0400
Received: from mx08-00178001.pphosted.com ([91.207.212.93]:52420 "EHLO
        mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1752638AbcKBNOo (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 2 Nov 2016 09:14:44 -0400
Subject: Re: [PATCH] mfd: stmpe: Fix RESET regression on STMPE2401
To: Linus Walleij <linus.walleij@linaro.org>, <lee.jones@linaro.org>,
        <linux-kernel@vger.kernel.org>
References: <1477992173-30964-1-git-send-email-linus.walleij@linaro.org>
CC: <stable@vger.kernel.org>, Amelie Delaunay <amelie.delaunay@st.com>
From: Patrice Chotard <patrice.chotard@st.com>
Message-ID: <cb0e0ee9-0dcc-1482-6a6b-6b1e5b5fbe1b@st.com>
Date: Wed, 2 Nov 2016 14:14:38 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1477992173-30964-1-git-send-email-linus.walleij@linaro.org>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.48.1.66]
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-02_03:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1935
Lines: 58



On 11/01/2016 10:22 AM, Linus Walleij wrote:
> Since commit c4dd1ba355aae2bc3d1213da6c66c53e3c31e028
> ("mfd: stmpe: Add reset support for all STMPE variant")
> we're resetting the STMPE expanders before use.
> 
> This caused a regression on the STMP2401 on the Nomadik
> NHK8815:
> 
> stmpe-i2c 0-0043: stmpe2401 detected, chip id: 0x101
> nmk-i2c 101f8000.i2c0: write to slave 0x43 timed out
> nmk-i2c 101f8000.i2c0: no ack received after address transmission
> stmpe-i2c 0-0044: stmpe2401 detected, chip id: 0x101
> nmk-i2c 101f8000.i2c0: write to slave 0x44 timed out
> nmk-i2c 101f8000.i2c0: no ack received after address transmission
> 
> It turns out that we start to poll for the reset bit to
> go low again too quickly: the STMPE2401 is not yet online and
> ready to be asked for the status of the RESET bit.
> 
> By introducing a 10ms delay before starting to hammer
> the register for information, we get back to normal:
> 
> stmpe-i2c 0-0043: stmpe2401 detected, chip id: 0x101
> stmpe-i2c 0-0044: stmpe2401 detected, chip id: 0x101
> 
> Cc: stable@vger.kernel.org
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Amelie Delaunay <amelie.delaunay@st.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Fixes: c4dd1ba355aa ("mfd: stmpe: Add reset support for all STMPE variant")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  drivers/mfd/stmpe.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
> index cfdae8a3d779..b0c7bcdaf5df 100644
> --- a/drivers/mfd/stmpe.c
> +++ b/drivers/mfd/stmpe.c
> @@ -851,6 +851,8 @@ static int stmpe_reset(struct stmpe *stmpe)
>  	if (ret < 0)
>  		return ret;
>  
> +	msleep(10);
> +
>  	timeout = jiffies + msecs_to_jiffies(100);
>  	while (time_before(jiffies, timeout)) {
>  		ret = __stmpe_reg_read(stmpe, stmpe->regs[STMPE_IDX_SYS_CTRL]);
> 


Hi Linus

Acked-by: Patrice Chotard <patrice.chotard@st.com>

Thanks