Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754598AbcKBNdr (ORCPT ); Wed, 2 Nov 2016 09:33:47 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35458 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754457AbcKBNdq (ORCPT ); Wed, 2 Nov 2016 09:33:46 -0400 Subject: Re: [PATCH 00/14] pinctrl-sx150x: Various bug-fixes and code simplifications To: Andrey Smirnov , linux-gpio@vger.kernel.org References: <1478015868-10309-1-git-send-email-andrew.smirnov@gmail.com> <9bc0e603-b861-85d8-914f-bd4b6e8a8020@baylibre.com> Cc: linus.walleij@linaro.org, linux-kernel@vger.kernel.org, cphealy@gmail.com From: Neil Armstrong Organization: Baylibre Message-ID: Date: Wed, 2 Nov 2016 14:33:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <9bc0e603-b861-85d8-914f-bd4b6e8a8020@baylibre.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2267 Lines: 61 On 11/02/2016 12:01 PM, Neil Armstrong wrote: > On 11/01/2016 04:57 PM, Andrey Smirnov wrote: >> Linus, Neil: >> >> I've had some help and got my hardware setup modified to enable IRQ >> functionality testing, so ended up looking at the code of SX150x more >> resulting in some code improvements (hopefully) and bugfixes. >> >> There are many small changes each of which is probably better >> described by corresponding commit's message, however the most >> porminenet changes of the whole patchset are the switch to regmap API >> (patches ## 7,8) and reduction of locking (patch # 9) >> >> Please let me know what you think. >> >> Thanks, >> Andrey >> >> Andrey Smirnov (14): >> pinctrl-sx150x: Rely on of_modalias_node for OF matching >> pinctrl-sx150x: Add SX1503 specific data >> pinctrl-sx150x: Replace magic number in sx150x_init_hw >> pinctrl-sx150x: Fix incorrect constant in sx150x_init_hw >> pinctrl-sx150x: Move some code out of sx150x_init_hw >> pinctrl-sx150x: Improve sx150x_init_misc for SX1504/5/6 >> pinctrl-sx150x: Convert driver to use regmap API >> pinctrl-sx150x: Replace sx150x_*_cfg by means of regmap API >> pinctrl-sx150x: Remove excessive locking >> pinctrl-sx150x: Improve oscio GPIO functions >> pinctrl-sx150x: Simplify interrupt handler >> pinctrl-sx150x: Use handle_bad_irq instead of handle_edge_irq >> pinctrl-sx150x: Remove magic numbers from sx150x_irq_set_type >> pinctrl-sx150x: Remove magic numbers from sx150x_reset >> >> drivers/pinctrl/pinctrl-sx150x.c | 753 +++++++++++++++++++++------------------ >> 1 file changed, 416 insertions(+), 337 deletions(-) >> > > Hi Andrey, > > This is good, you went faster than me ! > > Small point, could you add Kconfig dependency on REGMAP ? > > I will try out this patchset and hopefully get you a Tested-by in the next few days. > > Neil > Great, Successfully worked on 4.9-rc2 on my BeagleBone black installation with a SX1509. I got some rising and falling interrupts using gpio-event-mon. Small NIT: please add the sx1503 entry in the Kconfig desc and in the pinctrl-sx150x.txt bindings. Tested-by: Neil Armstrong With the Kconfig and bindings changes : Acked-by: Neil Armstrong Thanks, Neil