Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754784AbcKBO5H (ORCPT ); Wed, 2 Nov 2016 10:57:07 -0400 Received: from verein.lst.de ([213.95.11.211]:32962 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752806AbcKBO5F (ORCPT ); Wed, 2 Nov 2016 10:57:05 -0400 Date: Wed, 2 Nov 2016 15:57:03 +0100 From: Christoph Hellwig To: Jens Axboe Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, jack@suse.cz, hch@lst.de Subject: Re: [PATCH 4/8] writeback: track if we're sleeping on progress in balance_dirty_pages() Message-ID: <20161102145703.GH13964@lst.de> References: <1478034531-28559-1-git-send-email-axboe@fb.com> <1478034531-28559-5-git-send-email-axboe@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478034531-28559-5-git-send-email-axboe@fb.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 344 Lines: 9 On Tue, Nov 01, 2016 at 03:08:47PM -0600, Jens Axboe wrote: > Note in the bdi_writeback structure whenever a task ends up sleeping > waiting for progress. We can use that information in the lower layers > to increase the priority of writes. Do we need to care about atomicy of multiple threads updating the value ? Otherwise this looks fine.