Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755457AbcKBPQt (ORCPT <rfc822;w@1wt.eu>);
        Wed, 2 Nov 2016 11:16:49 -0400
Received: from mail-qk0-f193.google.com ([209.85.220.193]:36840 "EHLO
        mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752819AbcKBPQs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 2 Nov 2016 11:16:48 -0400
MIME-Version: 1.0
In-Reply-To: <20161102144211.GD19126@dragon>
References: <1477430817-20381-1-git-send-email-Frank.Li@nxp.com>
 <1477430817-20381-2-git-send-email-Frank.Li@nxp.com> <20161102144211.GD19126@dragon>
From: Zhi Li <lznuaa@gmail.com>
Date: Wed, 2 Nov 2016 10:16:46 -0500
Message-ID: <CAHrpEqRhuVbziEkU2Wp_+gad0SO3qRf20c_0NjS6o2Hk4pR-BA@mail.gmail.com>
Subject: Re: [PATCH 2/2] ARM: dts: add new compatible stream for i.MX6QP mmdc
To: Shawn Guo <shawnguo@kernel.org>
Cc: Frank Li <Frank.Li@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        kernel list <linux-kernel@vger.kernel.org>, peterz@infradead.org,
        mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com,
        Mark Rutland <mark.rutland@arm.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1327
Lines: 43

On Wed, Nov 2, 2016 at 9:42 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Tue, Oct 25, 2016 at 04:26:57PM -0500, Frank Li wrote:
>> mmdc of i.MX6QP are little difference with i.MX6Q.
>> added new compatible stream fsl,imx6qp-mmdc
>>
>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>> ---
>>  arch/arm/boot/dts/imx6qp.dtsi | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6qp.dtsi b/arch/arm/boot/dts/imx6qp.dtsi
>> index 886dbf2..e0fdd0f 100644
>> --- a/arch/arm/boot/dts/imx6qp.dtsi
>> +++ b/arch/arm/boot/dts/imx6qp.dtsi
>> @@ -85,5 +85,12 @@
>>               pcie: pcie@0x01000000 {
>>                       compatible = "fsl,imx6qp-pcie", "snps,dw-pcie";
>>               };
>> +
>> +             aips-bus@02100000 {
>> +                     mmdc0: mmdc@021b0000 { /* MMDC0 */
>> +                             compatible = "fsl,imx6qp-mmdc", "fsl,imx6q-mmdc";
>
> Sine we already know that imx6qp-mmdc has a different programming model
> from imx6q-mmdc, it makes less sense to have "fsl,imx6q-mmdc" here.

PM code (Suspend and resume) use  "fsl,imx6q-mmdc" to get mmdc's base
address to do some works.

best regards
Frank Li

>
> Shawn
>
>> +                             reg = <0x021b0000 0x4000>;
>> +                     };
>> +             };
>>       };
>>  };
>> --
>> 2.5.2
>>