Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755900AbcKBPsG (ORCPT ); Wed, 2 Nov 2016 11:48:06 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:35755 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753561AbcKBPsE (ORCPT ); Wed, 2 Nov 2016 11:48:04 -0400 MIME-Version: 1.0 X-Originating-IP: [172.56.10.86] In-Reply-To: <1476482095-26289-1-git-send-email-niklass@axis.com> References: <1476482095-26289-1-git-send-email-niklass@axis.com> From: Olof Johansson Date: Wed, 2 Nov 2016 08:48:02 -0700 Message-ID: Subject: Re: [PATCH] PCI: designware: check for iATU unroll support after initializing host To: Niklas Cassel , Bjorn Helgaas Cc: Jingoo Han , pratyush.anand@gmail.com, Joao.Pinto@synopsys.com, "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Niklas Cassel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 969 Lines: 25 Hi, On Fri, Oct 14, 2016 at 2:54 PM, Niklas Cassel wrote: > From: Niklas Cassel > > dw_pcie_iatu_unroll_enabled reads a dbi_base register. > Reading any dbi_base register before pp->ops->host_init has been called > causes "imprecise external abort" on platforms like ARTPEC-6, where the > PCIe module is disabled at boot and first enabled in pp->ops->host_init. > Move dw_pcie_iatu_unroll_enabled to dw_pcie_setup_rc, since it is after > pp->ops->host_init, but before pp->iatu_unroll_enabled is actually used. > > Fixes: a0601a470537 ("PCI: designware: Add iATU Unroll feature") > Signed-off-by: Niklas Cassel This fixes the regression I've seen on i.MX6 devices in my board farm as well. Acked-by: Olof Johansson Bjorn, can you please pick this up and get it sent up for 4.9-rc soon? I worry about losing bisectability if this remains broken for a while. Thanks! -Olof