Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933424AbcKBRS6 (ORCPT ); Wed, 2 Nov 2016 13:18:58 -0400 Received: from mail-lf0-f53.google.com ([209.85.215.53]:36436 "EHLO mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932635AbcKBRSz (ORCPT ); Wed, 2 Nov 2016 13:18:55 -0400 Subject: Re: [PATCH v5 4/7] Documentation: devicetree: net: add NS2 bindings to amac To: Jon Mason , David Miller , Rob Herring , Mark Rutland , Florian Fainelli References: <1478106488-11779-1-git-send-email-jon.mason@broadcom.com> <1478106488-11779-5-git-send-email-jon.mason@broadcom.com> Cc: rafal@milecki.pl, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: Date: Wed, 2 Nov 2016 20:18:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1478106488-11779-5-git-send-email-jon.mason@broadcom.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1615 Lines: 42 Hello. On 11/02/2016 08:08 PM, Jon Mason wrote: > Clean-up the documentation to the bgmac-amac driver, per suggestion by > Rob Herring, and add details for NS2 support. > > Signed-off-by: Jon Mason > --- > Documentation/devicetree/bindings/net/brcm,amac.txt | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/brcm,amac.txt b/Documentation/devicetree/bindings/net/brcm,amac.txt > index ba5ecc1..2fefa1a 100644 > --- a/Documentation/devicetree/bindings/net/brcm,amac.txt > +++ b/Documentation/devicetree/bindings/net/brcm,amac.txt > @@ -2,11 +2,17 @@ Broadcom AMAC Ethernet Controller Device Tree Bindings > ------------------------------------------------------------- > > Required properties: > - - compatible: "brcm,amac" or "brcm,nsp-amac" > - - reg: Address and length of the GMAC registers, > - Address and length of the GMAC IDM registers > - - reg-names: Names of the registers. Must have both "amac_base" and > - "idm_base" > + - compatible: "brcm,amac" > + "brcm,nsp-amac" > + "brcm,ns2-amac" > + - reg: Address and length of the register set for the device. It > + contains the information of registers in the same order as > + described by reg-names > + - reg-names: Names of the registers. > + "amac_base": Address and length of the GMAC registers > + "idm_base": Address and length of the GMAC IDM registers > + "nicpm_base": Address and length of the NIC Port Manager > + registers (required for Northstar2) Why this "_base" suffix? It looks redundant... [...] MBR, Sergei