Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756878AbcKBSgM (ORCPT ); Wed, 2 Nov 2016 14:36:12 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45542 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756388AbcKBSgJ (ORCPT ); Wed, 2 Nov 2016 14:36:09 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 3E1BA61513 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 2 Nov 2016 11:36:07 -0700 From: Stephen Boyd To: Michael Scott Cc: linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij , Rob Herring , Mark Rutland , Andy Gross , David Brown , Bjorn Andersson , Joonwoo Park , Jeremy McNicoll Subject: Re: [PATCH V4] pinctrl: qcom: Add msm8994 pinctrl driver Message-ID: <20161102183607.GJ16026@codeaurora.org> References: <20161031160009.20472-1-michael.scott@linaro.org> <20161101235344.GX16026@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1522 Lines: 41 On 11/01, Michael Scott wrote: > > On 11/01/2016 04:53 PM, Stephen Boyd wrote: > >On 10/31, Michael Scott wrote: > >>+ > >>+static const struct msm_pingroup msm8994_groups[] = { > >>+ PINGROUP(0, blsp_spi1, blsp_uart1, blsp_uim1, NA, NA, NA, NA, NA, NA, > >>+ NA, NA), > >I see an hdmi_rcv group here after blsp_uim1. Please add it for > >this gpio. > > Hi Stephen, > > Thank you for reviewing the data-- this is really tedious stuff. > > I'd like to make sure that we're both using tech data for msm8994. > I don't see the hdmi_rcv function at all in my docs. > > > > >>+ PINGROUP(1, blsp_spi1, blsp_uart1, blsp_uim1, NA, NA, NA, NA, NA, NA, > >>+ NA, NA), > >>+ PINGROUP(2, blsp_spi1, blsp_uart1, blsp_i2c1, NA, NA, NA, NA, NA, NA, > >>+ NA, NA), > >>+ PINGROUP(3, blsp_spi1, blsp_uart1, blsp_i2c1, NA, NA, NA, NA, NA, NA, > >>+ NA, NA), > >>+ PINGROUP(4, blsp_spi2, blsp_uart2, blsp_uim2, qdss_cti_trig_out_b, > >>+ NA, NA, NA, NA, NA, NA, NA), > >>+ PINGROUP(5, blsp_spi2, blsp_uart2, blsp_uim2, qdss_cti_trig_in_b, NA, > >The qdss_cti_* is in function 5 for both of these, not function > >4. > These are indeed wrong, but my docs both show as function 7. Ok. I think your document is for 8994v1, which never got commercialized. I certainly see that this function assignment changed between v1 and v2 from 7 to 5. Now that my eyes are bleeding I'm going to do something else. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project