Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755871AbcKBTYR (ORCPT ); Wed, 2 Nov 2016 15:24:17 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:57656 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752815AbcKBTYP (ORCPT ); Wed, 2 Nov 2016 15:24:15 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 625DB6156C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=spjoshi@codeaurora.org Subject: Re: [PATCH 2/3] firmware: qcom: scm: Remove core, iface and bus clocks dependency To: Stephen Boyd References: <1477699729-18451-1-git-send-email-spjoshi@codeaurora.org> <1477699729-18451-3-git-send-email-spjoshi@codeaurora.org> <20161101231101.GW16026@codeaurora.org> Cc: Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Jordan Crouse , Trilok Soni From: Sarangdhar Joshi Message-ID: <67b6f5ae-378e-9306-c717-2529ae84f9f7@codeaurora.org> Date: Wed, 2 Nov 2016 12:24:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161101231101.GW16026@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1615 Lines: 52 On 11/01/2016 04:11 PM, Stephen Boyd wrote: > On 10/28, Sarangdhar Joshi wrote: >> @@ -380,33 +384,43 @@ EXPORT_SYMBOL(qcom_scm_is_available); >> static int qcom_scm_probe(struct platform_device *pdev) >> { >> struct qcom_scm *scm; >> + uint64_t clks; >> int ret; >> >> scm = devm_kzalloc(&pdev->dev, sizeof(*scm), GFP_KERNEL); >> if (!scm) >> return -ENOMEM; >> >> - scm->core_clk = devm_clk_get(&pdev->dev, "core"); >> - if (IS_ERR(scm->core_clk)) { >> - if (PTR_ERR(scm->core_clk) == -EPROBE_DEFER) >> - return PTR_ERR(scm->core_clk); >> + clks = (uint64_t)of_device_get_match_data(&pdev->dev); >> + if (clks & SCM_HAS_CORE_CLK) { >> + scm->core_clk = devm_clk_get(&pdev->dev, "core"); >> + if (IS_ERR(scm->core_clk)) { >> + if (PTR_ERR(scm->core_clk) == -EPROBE_DEFER) >> + return PTR_ERR(scm->core_clk); >> >> - scm->core_clk = NULL; >> + scm->core_clk = NULL; >> + } >> } >> >> if (of_device_is_compatible(pdev->dev.of_node, "qcom,scm")) { > > Why didn't this also get added to the flags feature? I'd prefer > we either use of_device_is_compatible() for everything, or device > data to figure out what quirks to apply. You're right. These flags are already added for "qcom,scm" compatible. We can modify this to honor data flags only. I hope it's okay to update it in the same patch? Regards, Sarang > >> - scm->iface_clk = devm_clk_get(&pdev->dev, "iface"); >> - if (IS_ERR(scm->iface_clk)) { >> - if (PTR_ERR(scm->iface_clk) != -EPROBE_DEFER) > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project