Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756055AbcKBTdz (ORCPT ); Wed, 2 Nov 2016 15:33:55 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:45758 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755852AbcKBTdy (ORCPT ); Wed, 2 Nov 2016 15:33:54 -0400 Date: Wed, 02 Nov 2016 15:33:52 -0400 (EDT) Message-Id: <20161102.153352.177155711824743808.davem@davemloft.net> To: dongli.zhang@oracle.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH 1/1] xen-netfront: cast grant table reference first to type int From: David Miller In-Reply-To: <1478048673-26284-1-git-send-email-dongli.zhang@oracle.com> References: <1478048673-26284-1-git-send-email-dongli.zhang@oracle.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 02 Nov 2016 11:34:20 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 368 Lines: 10 From: Dongli Zhang Date: Wed, 2 Nov 2016 09:04:33 +0800 > IS_ERR_VALUE() in commit 87557efc27f6a50140fb20df06a917f368ce3c66 > ("xen-netfront: do not cast grant table reference to signed short") would > not return true for error code unless we cast ref first to type int. > > Signed-off-by: Dongli Zhang Applied.