From: Bough Chen <haibo.chen@nxp.com>
To: "Leonardo G. Veiga" <leogveiga@gmail.com>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "A.S. Dong" <aisheng.dong@nxp.com>
CC: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stefan@agner.ch" <stefan@agner.ch>,
        "raul.munoz@toradex.com" <raul.munoz@toradex.com>,
        "leonardo.veiga@toradex.com" <leonardo.veiga@toradex.com>
Subject: RE: [PATCH] sdhci-esdhc-imx: fix bus-width for 1-bit operation.
Thread-Topic: [PATCH] sdhci-esdhc-imx: fix bus-width for 1-bit operation.
Thread-Index: AQHSNFl5m+pZvjYKKEOY1ktSwSAoQ6DFGesg
Date: Wed, 2 Nov 2016 04:27:36 +0000
Message-ID: <AM4PR0401MB232475B15D7D9ED6B78A5E5E90A00@AM4PR0401MB2324.eurprd04.prod.outlook.com>
References: <1478015905-31262-1-git-send-email-leogveiga@gmail.com>
In-Reply-To: <1478015905-31262-1-git-send-email-leogveiga@gmail.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2016 04:27:36.8116
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR04MB1427
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uA2K4UCO010933
Content-Length: 2247
Lines: 61

+Aisheng.

Best Regards
Haibo Chen

> -----Original Message-----
> From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc-
> owner@vger.kernel.org] On Behalf Of Leonardo G. Veiga
> Sent: Tuesday, November 01, 2016 11:58 PM
> To: ulf.hansson@linaro.org
> Cc: linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org;
> stefan@agner.ch; raul.munoz@toradex.com; leonardo.veiga@toradex.com
> Subject: [PATCH] sdhci-esdhc-imx: fix bus-width for 1-bit operation.
> 
> From: Leonardo Graboski Veiga <leonardo.veiga@toradex.com>
> 
> The 1-bit operation mode, enabled by seeting the 'bus-width' property of the
> device tree 'esdhc' node to <1>, not work while using SD card.
> 
> The behavior is only noticed when only the data pin 0 is connected to the
> hardware. A series of kernel errors are printed to the console, all of them
> returning the following error message followed by some explanation:
> mmcblk0: error -84 transferring data
> 
> If four data lines are connected, it ignores the device-tree property and works
> in 4-bit mode of operation without errors. The hardware used for testing does
> not support 8-bit mode.
> 
> Check the 'bus-width' property and if set to <1>, enable the
> SDHCI_QUIRK_FORCE_1_BIT_DATA quirk.
> 
> Signed-off-by: Leonardo Graboski Veiga <leonardo.veiga@toradex.com>
> ---
>  drivers/mmc/host/sdhci-esdhc-imx.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-
> esdhc-imx.c
> index c9fbc4c3..88d7d22 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -1003,6 +1003,10 @@ sdhci_esdhc_imx_probe_dt(struct platform_device
> *pdev,
>  		host->quirks2 |= SDHCI_QUIRK2_NO_1_8_V;
>  	}
> 
> +	if (!of_property_read_u32(np, "bus-width", &boarddata-
> >max_bus_width)
> +		&& boarddata->max_bus_width == 1)
> +		host->quirks |= SDHCI_QUIRK_FORCE_1_BIT_DATA;
> +
>  	/* call to generic mmc_of_parse to support additional capabilities */
>  	ret = mmc_of_parse(host->mmc);
>  	if (ret)
> --
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the
> body of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html