Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932745AbcKBVHU (ORCPT ); Wed, 2 Nov 2016 17:07:20 -0400 Received: from mail-ua0-f169.google.com ([209.85.217.169]:34876 "EHLO mail-ua0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757347AbcKBVHT (ORCPT ); Wed, 2 Nov 2016 17:07:19 -0400 MIME-Version: 1.0 In-Reply-To: <20161102210331.GJ22791@arm.com> References: <20161031194414.61287-1-code@mmayer.net> <20161102210331.GJ22791@arm.com> From: Markus Mayer Date: Wed, 2 Nov 2016 14:07:17 -0700 Message-ID: Subject: Re: [PATCH] arm64: errata: Check for --fix-cortex-a53-843419 and --fix-cortex-a53 To: Will Deacon Cc: Markus Mayer , Catalin Marinas , ARM Kernel Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1403 Lines: 29 On 2 November 2016 at 14:03, Will Deacon wrote: > On Mon, Oct 31, 2016 at 12:44:14PM -0700, Markus Mayer wrote: >> From: Markus Mayer >> >> The new errata check leads to a warning with some older versions of the >> linker that do know how to work around the errata, but still use the >> original name of the command line option: --fix-cortex-a53. The commit >> in question that changed the name of the option can be found at [1]. >> It looks like only "gold" is affected by this rename. Traditional "ld" >> isn't. (There, the argument was always called --fix-cortex-a53-843419.) >> >> To allow older versions of gold to properly handle the erratum if they >> can, check whether ld supports the old name of this option in addition >> to checking the new one. >> >> [1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=7a2a1c793578a8468604e661dda025ecb8d0bd20;hp=cfbf0e3c5b637d66b2b1aeadecae9c187b825b2f >> >> Signed-off-by: Markus Mayer > > If newer versions of gold accept the correct option name, why do we care? Because Documentation/Changes states that the minimum requirement for binutils is 2.12. Right now, that is not really true. And not everybody can always use the newest toolchain, for various reasons. The question I am asking is: What do we have to lose by supporting both options? Thanks, -Markus