Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757492AbcKBVWU (ORCPT ); Wed, 2 Nov 2016 17:22:20 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:35231 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756401AbcKBVWS (ORCPT ); Wed, 2 Nov 2016 17:22:18 -0400 Date: Wed, 2 Nov 2016 22:22:00 +0100 From: Martin Schwidefsky To: Stanislaw Gruszka Cc: Christian Borntraeger , linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Frederic Weisbecker , Paul Mackerras , Benjamin Herrenschmidt , Michael Neuling , linuxppc-dev@lists.ozlabs.org, Heiko Carstens , linux-s390@vger.kernel.org Subject: Re: [PATCH 3/4] cputime/powerpc/s390: make scaled cputime arch specific In-Reply-To: <20161102093820.GC2604@redhat.com> References: <1477917389-11341-1-git-send-email-sgruszka@redhat.com> <1477917389-11341-4-git-send-email-sgruszka@redhat.com> <9ad862f2-5665-08d6-4e5d-793637efcb66@de.ibm.com> <20161102093820.GC2604@redhat.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16110221-0028-0000-0000-0000023E7E11 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16110221-0029-0000-0000-0000210BDDD8 Message-Id: <20161102222200.14bc8cb6@mschwide> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-02_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611020394 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1514 Lines: 35 On Wed, 2 Nov 2016 10:38:20 +0100 Stanislaw Gruszka wrote: > On Wed, Nov 02, 2016 at 10:11:22AM +0100, Christian Borntraeger wrote: > > On 10/31/2016 01:36 PM, Stanislaw Gruszka wrote: > > > Only s390 and powerpc have hardware facilities allowing to measure > > > cputimes scaled by frequency. On all other architectures > > > utimescaled/stimescaled are equal to utime/stime (however they are > > > accounted separately). > > > > > > Patch remove {u,s}timescaled accounting on all architectures except > > > powerpc and s390, where those values are explicitly accounted on proper > > > places. > > > > If we remove it everywhere else (and assuming that there are no users then) > > I aks myself if we should remove this as well from s390. > > There is one user of scaled cputimes values, it is taskstats (to users > space are exported ac_utimescaled, ac_stimescaled and > cpu_scaled_run_real_total which is calculated based on scaled times). > However on other than powerpc and s390 architectures scaled times are > equal to normal times (this is also true for older powerpc's without > SPURR/PURR registers). The taskstats interface is the only user of the scaled cputime that I am aware of. It is hard to say how valuable the information is. Without the scaled number in the taskstats inferface you have no means to detect if your workload has been affected by a another SMT thread running on the same core. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.