Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932910AbcKBVia (ORCPT ); Wed, 2 Nov 2016 17:38:30 -0400 Received: from vern.gendns.com ([206.190.152.46]:50667 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932809AbcKBVi2 (ORCPT ); Wed, 2 Nov 2016 17:38:28 -0400 Subject: Re: [PATCH 1/3] ARM: davinci: da8xx: Fix ohci driver name To: Axel Haslam , khilman@kernel.org, nsekhar@ti.com, gregkh@linuxfoundation.org, kishon@ti.com References: <20161102124435.31777-1-ahaslam@baylibre.com> <20161102124435.31777-2-ahaslam@baylibre.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org From: David Lechner Message-ID: Date: Wed, 2 Nov 2016 16:38:24 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161102124435.31777-2-ahaslam@baylibre.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 651 Lines: 20 On 11/02/2016 07:44 AM, Axel Haslam wrote: > There is a single instance of the ohci driver, > while the clk lookup table is making reference to "ohci" > other subsystems (such as phy) are looking for "ohci.0" > This patch changes the "device" name, not the "driver" name. You use "driver" above and in the subject. > Since there is a single ohci instance, change the dev id > to -1, and add the "-da8xx" for consitancy with the musb > driver name. It would be more accurate to say that you are adding "-da8xx" because you are also changing the ohci _driver_ name in a separate patch. > > Signed-off-by: Axel Haslam > ---