Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933044AbcKBVqO (ORCPT ); Wed, 2 Nov 2016 17:46:14 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:56914 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877AbcKBVqN (ORCPT ); Wed, 2 Nov 2016 17:46:13 -0400 Date: Wed, 2 Nov 2016 22:45:59 +0100 From: Ladislav Michl To: David Lechner Cc: Bin Liu , Greg Kroah-Hartman , Alexandre Bailon , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: musb: da8xx: Don't print phy error on -EPROBE_DEFER Message-ID: <20161102214559.GA2338@localhost.localdomain> References: <1477422170-1490-1-git-send-email-david@lechnology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477422170-1490-1-git-send-email-david@lechnology.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1095 Lines: 35 Hi, On Tue, Oct 25, 2016 at 02:02:50PM -0500, David Lechner wrote: > This suppresses printing the error message "failed to get phy" in the > kernel log when the error is -EPROBE_DEFER. This prevents usless noise > in the kernel log. > > Signed-off-by: David Lechner > --- > drivers/usb/musb/da8xx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c > index 481d786..f8a1591 100644 > --- a/drivers/usb/musb/da8xx.c > +++ b/drivers/usb/musb/da8xx.c > @@ -516,7 +516,8 @@ static int da8xx_probe(struct platform_device *pdev) > > glue->phy = devm_phy_get(&pdev->dev, "usb-phy"); > if (IS_ERR(glue->phy)) { > - dev_err(&pdev->dev, "failed to get phy\n"); > + if (PTR_ERR(glue->phy) != -EPROBE_DEFER) > + dev_err(&pdev->dev, "failed to get phy\n"); What about something like this? dev_printk(PTR_ERR(glue->phy) == -EPROBE_DEFER ? KERN_DEBUG : KERN_ERR, ... At least it outputs something if debug is enabled, making debugging easier. ladis > return PTR_ERR(glue->phy); > } >