Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757638AbcKBXWp (ORCPT ); Wed, 2 Nov 2016 19:22:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34174 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756406AbcKBXWn (ORCPT ); Wed, 2 Nov 2016 19:22:43 -0400 Subject: Re: [PATCH V4] pinctrl: qcom: Add msm8994 pinctrl driver To: Stephen Boyd , Michael Scott References: <20161031160009.20472-1-michael.scott@linaro.org> <20161101235344.GX16026@codeaurora.org> <20161102183607.GJ16026@codeaurora.org> Cc: linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij , Rob Herring , Mark Rutland , Andy Gross , David Brown , Bjorn Andersson , Joonwoo Park , Jeremy McNicoll From: Jeremy McNicoll Organization: Red Hat Message-ID: Date: Wed, 2 Nov 2016 16:22:53 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161102183607.GJ16026@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 02 Nov 2016 23:22:42 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1615 Lines: 44 On 2016-11-02 11:36 AM, Stephen Boyd wrote: > On 11/01, Michael Scott wrote: >> >> On 11/01/2016 04:53 PM, Stephen Boyd wrote: >>> On 10/31, Michael Scott wrote: >>>> + >>>> +static const struct msm_pingroup msm8994_groups[] = { >>>> + PINGROUP(0, blsp_spi1, blsp_uart1, blsp_uim1, NA, NA, NA, NA, NA, NA, >>>> + NA, NA), >>> I see an hdmi_rcv group here after blsp_uim1. Please add it for >>> this gpio. >> >> Hi Stephen, >> >> Thank you for reviewing the data-- this is really tedious stuff. >> >> I'd like to make sure that we're both using tech data for msm8994. >> I don't see the hdmi_rcv function at all in my docs. >> >>> >>>> + PINGROUP(1, blsp_spi1, blsp_uart1, blsp_uim1, NA, NA, NA, NA, NA, NA, >>>> + NA, NA), >>>> + PINGROUP(2, blsp_spi1, blsp_uart1, blsp_i2c1, NA, NA, NA, NA, NA, NA, >>>> + NA, NA), >>>> + PINGROUP(3, blsp_spi1, blsp_uart1, blsp_i2c1, NA, NA, NA, NA, NA, NA, >>>> + NA, NA), >>>> + PINGROUP(4, blsp_spi2, blsp_uart2, blsp_uim2, qdss_cti_trig_out_b, >>>> + NA, NA, NA, NA, NA, NA, NA), >>>> + PINGROUP(5, blsp_spi2, blsp_uart2, blsp_uim2, qdss_cti_trig_in_b, NA, >>> The qdss_cti_* is in function 5 for both of these, not function >>> 4. >> These are indeed wrong, but my docs both show as function 7. > > Ok. I think your document is for 8994v1, which never got > commercialized. I certainly see that this function assignment > changed between v1 and v2 from 7 to 5. > This is a case where not having the docs and only downstream code as a reference is probably a good thing (tm), although the downstream code may end up hurting more than helping. -jeremy