Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752470AbcKCBAI (ORCPT ); Wed, 2 Nov 2016 21:00:08 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:34105 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751135AbcKCBAG (ORCPT ); Wed, 2 Nov 2016 21:00:06 -0400 Subject: Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower To: John Heenan , Jes Sorensen , Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org References: <20161030102112.GA5789@cube> Cc: linux-kernel@vger.kernel.org From: Larry Finger Message-ID: <10e32bb4-fe16-6a0f-eaf4-1142c23e7b56@lwfinger.net> Date: Wed, 2 Nov 2016 20:00:03 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161030102112.GA5789@cube> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 888 Lines: 23 On 10/30/2016 05:21 AM, John Heenan wrote: > Code tests show data returned by rtl8xxxu_read8(priv, REG_CR), used to set > macpower, is never 0xea. It is only ever 0x01 (first time after modprobe) > using wpa_supplicant and 0x00 thereafter using wpa_supplicant. These results > occurs with 'Fix for authentication failure' [PATCH 1/2] in place. > > Whatever was returned, code tests always showed that at least > rtl8xxxu_init_queue_reserved_page(priv); > is always required. Not called if macpower set to true. > > Please see cover letter, [PATCH 0/2], for more information from tests. That cover letter will NOT be included in the commit message, thus referring to it here is totally pointless. > > For rtl8xxxu-devel branch of git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git Same comment as for the previous patch. Again I leave the review of the code changes to Jes. Larry