Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753282AbcKCBAQ (ORCPT ); Wed, 2 Nov 2016 21:00:16 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:35160 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752715AbcKCBAN (ORCPT ); Wed, 2 Nov 2016 21:00:13 -0400 Subject: Re: [PATCH 1/2] rtl8xxxu: Fix for authentication failure To: John Heenan , Jes Sorensen , Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org References: <20161030102046.GA5784@cube> Cc: linux-kernel@vger.kernel.org From: Larry Finger Message-ID: <8dba6346-332e-84e6-89b2-02033a449f25@lwfinger.net> Date: Wed, 2 Nov 2016 20:00:11 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161030102046.GA5784@cube> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2332 Lines: 67 On 10/30/2016 05:20 AM, John Heenan wrote: > This fix enables the same sequence of init behaviour as the alternative > working driver for the wireless rtl8723bu IC at > https://github.com/lwfinger/rtl8723bu > > For exampe rtl8xxxu_init_device is now called each time > userspace wpa_supplicant is executed instead of just once when > modprobe is executed. After all the trouble you have had with your patches, I would expect you to use more care when composing the commit message. Note the typo in the paragraph above. > Along with 'Fix for bogus data used to determine macpower', > wpa_supplicant now reliably and successfully authenticates. I'm not sure this paragraph belongs in the permanent commit record. > For rtl8xxxu-devel branch of git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git I know this line does not belong. If you want to include information like this, include it after a line containing "---". Those lines will be available to reviewers and maintainers, but will be stripped before it gets included in the code base. > Signed-off-by: John Heenan > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > index 04141e5..f25b4df 100644 > --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > @@ -5779,6 +5779,11 @@ static int rtl8xxxu_start(struct ieee80211_hw *hw) > > ret = 0; > > + ret = rtl8xxxu_init_device(hw); > + if (ret) > + goto error_out; > + > + > init_usb_anchor(&priv->rx_anchor); > init_usb_anchor(&priv->tx_anchor); > init_usb_anchor(&priv->int_anchor); > @@ -6080,10 +6085,6 @@ static int rtl8xxxu_probe(struct usb_interface *interface, > goto exit; > } > > - ret = rtl8xxxu_init_device(hw); > - if (ret) > - goto exit; > - > hw->wiphy->max_scan_ssids = 1; > hw->wiphy->max_scan_ie_len = IEEE80211_MAX_DATA_LEN; > hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION); > I will let Jes comment on any side effects of this code change. Larry -- If I was stranded on an island and the only way to get off the island was to make a pretty UI, I?d die there. Linus Torvalds