Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752243AbcKCEPF (ORCPT ); Thu, 3 Nov 2016 00:15:05 -0400 Received: from smtp.nue.novell.com ([195.135.221.5]:52662 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750838AbcKCEPE (ORCPT ); Thu, 3 Nov 2016 00:15:04 -0400 Date: Thu, 3 Nov 2016 12:14:50 +0800 From: joeyli To: Anthony Wong Cc: "Lee, Chun-Yi" , Darren Hart , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] acer-wmi: only supports AMW0_GUID1 on acer family Message-ID: <20161103041450.GI18823@linux-rxt1.site> References: <1477974658-12589-1-git-send-email-jlee@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1214 Lines: 32 On Thu, Nov 03, 2016 at 11:40:15AM +0800, Anthony Wong wrote: > On 1 November 2016 at 12:30, Lee, Chun-Yi wrote: > > > > The AMW0_GUID1 wmi is not only found on Acer family but also other > > machines like Lenovo, Fujitsu and Medion. In the past days, acer-wmi > > driver handled those non-Acer machines by quirks list. > > > > But actually acer-wmi driver was loaded on any machines that have > > AMW0_GUID1. This behavior is strange because those machines should > > be supported by appropriate wmi drivers. e.g. fujitsu-laptop, > > ideapad-laptop. > > > > So, This patch adds the logic to check the machine that has AMW0_GUID1 > > should be in Acer/Packard Bell/Gateway white list. But, it still keeps > > the quirk list of those supported non-acer machines for backward > > compatible. > > > > Tested-by: Bj?rn Mork > > Cc: Darren Hart > > Signed-off-by: Lee, Chun-Yi > > Xiaomi Air 13.3 notebook suffers from the same issue, acer-wmi > basically has no use on this machine. With your patch, acer-wmi no > longer loads. > > Tested-by: Anthony Wong > > Thanks, > Anthony Thanks for your testing! Joey Lee