Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755551AbcKCILH (ORCPT ); Thu, 3 Nov 2016 04:11:07 -0400 Received: from b.ns.miles-group.at ([95.130.255.144]:44723 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754428AbcKCILE (ORCPT ); Thu, 3 Nov 2016 04:11:04 -0400 Subject: Re: UBIFS LEB properties tree with odd addresses To: Naga Sureshkumar Relli , Christoph Hellwig References: Cc: "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "dedekind1@gmail.com" , "adrian.hunter@intel.com" , "michal.simek@xilinx.com" , Punnaiah Choudary Kalluri , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Boris Brezillon From: Richard Weinberger Message-ID: Date: Thu, 3 Nov 2016 09:10:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1300 Lines: 32 Naga Sureshkumar Relli, On 03.11.2016 06:11, Naga Sureshkumar Relli wrote: > Hi Richard, > >>> Hmm, the calculations in lpt.c use basic properties of the MTD (number of blocks, etc...). >>> Can you please double check which property causes the failure and also verify whether the MTD driver provides correct properties. i.e. page sizes, block size, number of blocks, ... > >> Hm, these values depend only on basic MTD prperties AFAICT. >> Mtd->numeraseregions = 0 >> Nor->pagesize = 512 > > As per the above query only, I have given the below inputs. >> Maybe you miss some bit and set incorrect MTD properties. > I double checked the MTD properties (as mentioned above) which were causing the failure, but didn't find any clue. > All mtd properties looks good for dual parallel case(there is no odd value). > > Is there any impact by putting below logic in do_calc_lpt_geom() ? > If(c->pnode_sz % 2) > c->pnode_sz += 1; Yes, we need to understand first what exactly is going on. > please suggest me to do any further debugging? Please find the exact MTD property which causes the odd values. Can you also please share the full kernel log of both cases? (dual and non-dual). I'm especially interested in the output of UBI. I have the feeling that we oversee something. Thanks, //richard