Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756426AbcKCIxL (ORCPT ); Thu, 3 Nov 2016 04:53:11 -0400 Received: from lucky1.263xmail.com ([211.157.147.132]:42423 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756365AbcKCIxJ (ORCPT ); Thu, 3 Nov 2016 04:53:09 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED4: 1 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] clk: rockchip: fix some clocks' name to be more standard style To: Jianqun Xu , mturquette@baylibre.com, sboyd@codeaurora.org, heiko@sntech.de, huangtao@rock-chips.com, zhangqing@rock-chips.com, zhengxing@rock-chips.com References: <1478070296-23080-1-git-send-email-jay.xu@rock-chips.com> Cc: shawn.lin@rock-chips.com, linux-kernel@vger.kernel.org, lintao@rock-chips.com, linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Shawn Lin Message-ID: <763cad68-a068-9a4b-e26d-2c459c2d4808@rock-chips.com> Date: Thu, 3 Nov 2016 16:52:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1478070296-23080-1-git-send-email-jay.xu@rock-chips.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1438 Lines: 39 On 2016/11/2 15:04, Jianqun Xu wrote: > Fix aclk_emmcgrf to aclk_emmc_grf, and fix aclk_emmccore to be > aclk_emmc_core. > What is the standard style should be? TRM uses aclk_emmccore but not aclk_emmc_core, so should it be more standrad to keep it as-is? > Signed-off-by: Jianqun Xu > --- > drivers/clk/rockchip/clk-rk3399.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c > index 2c7cba7..b3df2c6 100644 > --- a/drivers/clk/rockchip/clk-rk3399.c > +++ b/drivers/clk/rockchip/clk-rk3399.c > @@ -935,11 +935,11 @@ static struct rockchip_clk_branch rk3399_clk_branches[] __initdata = { > RK3399_CLKGATE_CON(6), 13, GFLAGS), > COMPOSITE_NOGATE(ACLK_EMMC, "aclk_emmc", mux_aclk_emmc_p, CLK_IGNORE_UNUSED, > RK3399_CLKSEL_CON(21), 7, 1, MFLAGS, 0, 5, DFLAGS), > - GATE(ACLK_EMMC_CORE, "aclk_emmccore", "aclk_emmc", CLK_IGNORE_UNUSED, > + GATE(ACLK_EMMC_CORE, "aclk_emmc_core", "aclk_emmc", CLK_IGNORE_UNUSED, > RK3399_CLKGATE_CON(32), 8, GFLAGS), > GATE(ACLK_EMMC_NOC, "aclk_emmc_noc", "aclk_emmc", CLK_IGNORE_UNUSED, > RK3399_CLKGATE_CON(32), 9, GFLAGS), > - GATE(ACLK_EMMC_GRF, "aclk_emmcgrf", "aclk_emmc", CLK_IGNORE_UNUSED, > + GATE(ACLK_EMMC_GRF, "aclk_emmc_grf", "aclk_emmc", CLK_IGNORE_UNUSED, > RK3399_CLKGATE_CON(32), 10, GFLAGS), > > /* perilp0 */ > -- Best Regards Shawn Lin