Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756712AbcKCK3a (ORCPT ); Thu, 3 Nov 2016 06:29:30 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:13909 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752077AbcKCK32 (ORCPT ); Thu, 3 Nov 2016 06:29:28 -0400 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 03 Nov 2016 03:29:26 -0700 Subject: Re: [PATCH V3 5/6] ARM: tegra: Add Tegra20 GMI support To: Mirza Krak , , References: <1477576872-2665-1-git-send-email-mirza.krak@gmail.com> <1477576872-2665-6-git-send-email-mirza.krak@gmail.com> CC: , , , , , , , , , , , , From: Jon Hunter Message-ID: Date: Thu, 3 Nov 2016 10:29:14 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1477576872-2665-6-git-send-email-mirza.krak@gmail.com> X-Originating-IP: [10.21.132.110] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1646 Lines: 67 On 27/10/16 15:01, Mirza Krak wrote: > From: Mirza Krak > > Add a device node for the GMI controller found on Tegra20. > > Signed-off-by: Mirza Krak > Tested-by: Marcel Ziswiler > Tested-on: Colibri T20/T30 on EvalBoard V3.x and GMI-Memory Board > --- > > Changes in v2: > - added address-cells, size-cells and ranges properties > > Changes in v3: > - fixed range address which is not the same as Tegra30. > > arch/arm/boot/dts/tegra20.dtsi | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi > index 2207c08..b22cddb 100644 > --- a/arch/arm/boot/dts/tegra20.dtsi > +++ b/arch/arm/boot/dts/tegra20.dtsi > @@ -1,4 +1,4 @@ > -#include > +include After fixing up this, can you also ... > #include > #include > #include > @@ -376,6 +376,20 @@ > status = "disabled"; > }; > > + Drop this additional line? > + gmi@70009000 { > + compatible = "nvidia,tegra20-gmi"; > + reg = <0x70009000 0x1000>; > + #address-cells = <2>; > + #size-cells = <1>; > + ranges = <0 0 0xd0000000 0xfffffff>; > + clocks = <&tegra_car TEGRA20_CLK_NOR>; > + clock-names = "gmi"; > + resets = < &tegra_car 42>; Get rid of this additional space? > + reset-names = "gmi"; > + status = "disabled"; > + }; > + Otherwise ... Acked-by: Jon Hunter Cheers Jon -- nvpublic