Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757311AbcKCLMn (ORCPT ); Thu, 3 Nov 2016 07:12:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47686 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757237AbcKCLMk (ORCPT ); Thu, 3 Nov 2016 07:12:40 -0400 Date: Thu, 3 Nov 2016 12:12:38 +0100 From: Artem Savkov To: Suzuki K Poulose Cc: Will Deacon , Catalin Marinas , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: arm64 build failure with CONFIG_ARM64_LSE_ATOMICS=y Message-ID: <20161103111238.GC24243@shodan.usersys.redhat.com> References: <20161102164427.GB24243@shodan.usersys.redhat.com> <20161102232854.GO22791@arm.com> <1efb101a-a8ab-5ad9-f2bd-e7d485c71904@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1efb101a-a8ab-5ad9-f2bd-e7d485c71904@arm.com> User-Agent: Mutt/1.7+2 (e5fcfc5f9c2e) (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 03 Nov 2016 11:12:39 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2962 Lines: 69 On Thu, Nov 03, 2016 at 10:39:43AM +0000, Suzuki K Poulose wrote: > On 02/11/16 23:28, Will Deacon wrote: > > Hi Artem, > > > > On Wed, Nov 02, 2016 at 05:44:27PM +0100, Artem Savkov wrote: > > > Hello Catalin, > > > > > > Looks like your patch "efd9e03 arm64: Use static keys for CPU features" > > > breaks arm64 build with "CONFIG_ARM64_LSE_ATOMICS=y" because it creates a > > > circular dependency for asm/lse.h through jump_label.h: > > > > > > CC arch/arm64/kernel/asm-offsets.s > > > In file included from ./arch/arm64/include/asm/atomic.h:34:0, > > > from ./include/linux/atomic.h:4, > > > from ./include/linux/jump_label.h:169, > > > from ./arch/arm64/include/asm/cpufeature.h:12, > > > from ./arch/arm64/include/asm/alternative.h:4, > > > from ./arch/arm64/include/asm/lse.h:7, > > > from ./arch/arm64/include/asm/spinlock.h:19, > > > from ./include/linux/spinlock.h:87, > > > from ./include/linux/seqlock.h:35, > > > from ./include/linux/time.h:5, > > > from ./include/uapi/linux/timex.h:56, > > > from ./include/linux/timex.h:56, > > > from ./include/linux/sched.h:19, > > > from arch/arm64/kernel/asm-offsets.c:21: > > > ./arch/arm64/include/asm/atomic_lse.h: In function ‘atomic_andnot’: > > > ./arch/arm64/include/asm/atomic_lse.h:35:15: error: expected string literal before ‘ ’ > > > asm volatile(ARM64_LSE_ATOMIC_INSN(__LL_SC_ATOMIC(op), \ > > > > > > ... > > > > > > ./arch/arm64/include/asm/cmpxchg.h: In function ‘__xchg_case_1’: > > > ./arch/arm64/include/asm/cmpxchg.h:38:15: error: expected string literal before ‘ARM64_LSE_ATOMIC_INSN’ > > > asm volatile(ARM64_LSE_ATOMIC_INSN( \ > > > > I'm unable to reproduce this. I've tried enabling LSE with defconfig and > > mainline, using compilers that both do and don't support the instructions. > > I am not able to reproduce it either. One minor problem I see with the commit could > be fixed with the following change : Does it help ? Apparently it fails with an older gcc (4.8.5), but doesn't with 6.2.0. The different bit is that with 4.8.5 I don't have CC_HAVE_ASM_GOTO set. It is reproducible with 6.2.0 if you manually remove CC_HAVE_ASM_GOTO. > ----8>----- > > diff --git a/arch/arm64/include/asm/cpufeature.h b/arch/arm64/include/asm/cpufeature.h > index 758d74f..62db988 100644 > --- a/arch/arm64/include/asm/cpufeature.h > +++ b/arch/arm64/include/asm/cpufeature.h > @@ -9,7 +9,6 @@ > #ifndef __ASM_CPUFEATURE_H > #define __ASM_CPUFEATURE_H > -#include > #include > #include > @@ -45,6 +44,7 @@ > #ifndef __ASSEMBLY__ > +#include > #include > /* CPU feature register tracking */ No, this doesn't help. -- Regards, Artem