Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754554AbcKCMUO (ORCPT ); Thu, 3 Nov 2016 08:20:14 -0400 Received: from lb3-smtp-cloud6.xs4all.net ([194.109.24.31]:43550 "EHLO lb3-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754355AbcKCMUM (ORCPT ); Thu, 3 Nov 2016 08:20:12 -0400 Subject: Re: [PATCH 10/34] [media] DaVinci-VPBE: Check return value of a setup_if_config() call in vpbe_set_output() To: SF Markus Elfring , linux-media@vger.kernel.org, Hans Verkuil , "Lad, Prabhakar" , Manjunath Hadli , Mauro Carvalho Chehab References: <47590f2e-1cfa-582d-769e-502802171b66@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Hans Verkuil Message-ID: Date: Thu, 3 Nov 2016 13:20:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <47590f2e-1cfa-582d-769e-502802171b66@users.sourceforge.net> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1866 Lines: 55 On 12/10/16 16:47, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 12 Oct 2016 09:56:56 +0200 > > * A function was called over the pointer "setup_if_config" in the data > structure "venc_platform_data". But the return value was not used so far. > Thus assign it to the local variable "ret" which will be checked with > the next statement. > > Fixes: 9a7f95ad1c946efdd7a7a72df27db738260a0fd8 ("[media] davinci vpbe: add dm365 VPBE display driver changes") > > * Pass a value to this function call without storing it in an intermediate > variable before. > > * Delete the local variable "if_params" which became unnecessary with > this refactoring. > > Signed-off-by: Markus Elfring > --- > drivers/media/platform/davinci/vpbe.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c > index 19611a2..6e7b0df 100644 > --- a/drivers/media/platform/davinci/vpbe.c > +++ b/drivers/media/platform/davinci/vpbe.c > @@ -227,7 +227,6 @@ static int vpbe_set_output(struct vpbe_device *vpbe_dev, int index) > vpbe_current_encoder_info(vpbe_dev); > struct vpbe_config *cfg = vpbe_dev->cfg; > struct venc_platform_data *venc_device = vpbe_dev->venc_device; > - u32 if_params; > int enc_out_index; > int sd_index; > int ret = 0; > @@ -257,8 +256,8 @@ static int vpbe_set_output(struct vpbe_device *vpbe_dev, int index) > goto out; > } > > - if_params = cfg->outputs[index].if_params; > - venc_device->setup_if_config(if_params); > + ret = venc_device->setup_if_config(cfg > + ->outputs[index].if_params); Either keep this as one line or keep the if_params temp variable. This odd linebreak is ugly. Regards, Hans > if (ret) > goto out; > } >