Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756409AbcKCMlI (ORCPT ); Thu, 3 Nov 2016 08:41:08 -0400 Received: from lb3-smtp-cloud6.xs4all.net ([194.109.24.31]:54621 "EHLO lb3-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754668AbcKCMlH (ORCPT ); Thu, 3 Nov 2016 08:41:07 -0400 Subject: Re: [PATCH 3/3] [media] au0828-video: Move two assignments in au0828_init_isoc() To: SF Markus Elfring , linux-media@vger.kernel.org, Hans Verkuil , Laurent Pinchart , Mauro Carvalho Chehab , =?UTF-8?Q?Rafael_Louren=c3=a7o_de_Lima_Chehab?= , Shuah Khan , Wolfram Sang References: <1ab6b168-3c69-97c2-d02e-cd64b7fa222f@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: Hans Verkuil Message-ID: <4e6e77af-1b2c-33a6-1bc3-058ac5ecc038@xs4all.nl> Date: Thu, 3 Nov 2016 13:41:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1ab6b168-3c69-97c2-d02e-cd64b7fa222f@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1692 Lines: 49 On 24/10/16 23:01, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 24 Oct 2016 22:44:02 +0200 > > Move the assignment for the data structure members "isoc_copy" > and "num_bufs" behind the source code for memory allocations > by this function. I don't see the point, dropping this patch. Hans > > Signed-off-by: Markus Elfring > --- > drivers/media/usb/au0828/au0828-video.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c > index b5c88a7..5ebda64 100644 > --- a/drivers/media/usb/au0828/au0828-video.c > +++ b/drivers/media/usb/au0828/au0828-video.c > @@ -218,9 +218,6 @@ static int au0828_init_isoc(struct au0828_dev *dev, int max_packets, > int rc; > > au0828_isocdbg("au0828: called au0828_prepare_isoc\n"); > - > - dev->isoc_ctl.isoc_copy = isoc_copy; > - dev->isoc_ctl.num_bufs = num_bufs; > dev->isoc_ctl.urb = kcalloc(num_bufs, > sizeof(*dev->isoc_ctl.urb), > GFP_KERNEL); > @@ -240,6 +237,7 @@ static int au0828_init_isoc(struct au0828_dev *dev, int max_packets, > dev->isoc_ctl.buf = NULL; > > sb_size = max_packets * dev->isoc_ctl.max_pkt_size; > + dev->isoc_ctl.num_bufs = num_bufs; > > /* allocate urbs and transfer buffers */ > for (i = 0; i < dev->isoc_ctl.num_bufs; i++) { > @@ -276,6 +274,7 @@ static int au0828_init_isoc(struct au0828_dev *dev, int max_packets, > k += dev->isoc_ctl.max_pkt_size; > } > } > + dev->isoc_ctl.isoc_copy = isoc_copy; > > /* submit urbs and enables IRQ */ > for (i = 0; i < dev->isoc_ctl.num_bufs; i++) { >