Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755167AbcKCNam (ORCPT ); Thu, 3 Nov 2016 09:30:42 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36041 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754205AbcKCNaf (ORCPT ); Thu, 3 Nov 2016 09:30:35 -0400 Subject: Re: [PATCH 2/5] KVM: x86: do not scan IRR twice on APICv vmentry To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <1476469291-5039-1-git-send-email-pbonzini@redhat.com> <1476469291-5039-3-git-send-email-pbonzini@redhat.com> <20161026195900.GC4212@potion> Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, yang.zhang.wz@gmail.com, feng.wu@intel.com, mst@redhat.com From: Paolo Bonzini Message-ID: <00273a1a-ef5d-f814-3e02-24b4e855d229@redhat.com> Date: Thu, 3 Nov 2016 14:30:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161026195900.GC4212@potion> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 587 Lines: 18 On 26/10/2016 21:59, Radim Krčmář wrote: > 2016-10-14 20:21+0200, Paolo Bonzini: >> Calling apic_find_highest_irr results in IRR being scanned twice, >> once in vmx_sync_pir_from_irr and once in apic_search_irr. Change >> sync_pir_from_irr to do the RVI write and kvm_apic_update_irr to >> compute the new RVI on the fly. >> >> Signed-off-by: Paolo Bonzini >> --- > > Reviewed-by: Radim Krčmář Nope, this breaks nested VMX exit on external interrupt. For now I'm testing only patch 1 and will push that one only to kvm/next. Paolo