Date: Thu, 3 Nov 2016 15:53:44 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        yang.zhang.wz@gmail.com, feng.wu@intel.com
Subject: Re: [PATCH 2/5] KVM: x86: do not scan IRR twice on APICv vmentry
Message-ID: <20161103155249-mutt-send-email-mst@kernel.org>
References: <1476469291-5039-1-git-send-email-pbonzini@redhat.com>
 <1476469291-5039-3-git-send-email-pbonzini@redhat.com>
 <20161026195900.GC4212@potion>
 <00273a1a-ef5d-f814-3e02-24b4e855d229@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <00273a1a-ef5d-f814-3e02-24b4e855d229@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 724
Lines: 21

On Thu, Nov 03, 2016 at 02:30:31PM +0100, Paolo Bonzini wrote:
> 
> 
> On 26/10/2016 21:59, Radim Krčmář wrote:
> > 2016-10-14 20:21+0200, Paolo Bonzini:
> >> Calling apic_find_highest_irr results in IRR being scanned twice,
> >> once in vmx_sync_pir_from_irr and once in apic_search_irr.  Change
> >> sync_pir_from_irr to do the RVI write and kvm_apic_update_irr to
> >> compute the new RVI on the fly.
> >>
> >> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >> ---
> > 
> > Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
> 
> Nope, this breaks nested VMX exit on external interrupt.  For now I'm
> testing only patch 1 and will push that one only to kvm/next.
> 
> Paolo

Do you know why? I don't see it yet.