Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757380AbcKCN5j (ORCPT ); Thu, 3 Nov 2016 09:57:39 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:37171 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751539AbcKCN5g (ORCPT ); Thu, 3 Nov 2016 09:57:36 -0400 Subject: Re: [PATCH] block: drop q argument from bsg_validate_sgv4_hdr To: Johannes Thumshirn References: <20161103093854.3690-1-jthumshirn@suse.de> CC: Hannes Reinecke , Christoph Hellwig , Linux Kernel Mailinglist , "Linux Block Layer Mailinglist" From: Jens Axboe Message-ID: Date: Thu, 3 Nov 2016 07:56:58 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161103093854.3690-1-jthumshirn@suse.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.134.26.173] X-ClientProxiedBy: BY2PR1001CA0047.namprd10.prod.outlook.com (10.164.163.15) To CY4PR15MB1189.namprd15.prod.outlook.com (10.172.177.11) X-MS-Office365-Filtering-Correlation-Id: 62960b54-4dbf-43c4-cc86-08d403f14b74 X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;2:6brIA1qw4jTd3IchHEZ5LsgKY9a3lHqagTdH5Iy5nokoSc44jQCWugR7StDcQKNF8H8HadFOj+pcukq70gqqjOLGoMxH5QbQxOp0zg1tyLH78Z0fAci11Z/GkBge0jMF0nj+ce5SirZzNgOGnetGm/rXC+kCLTrQTHzCA6bXdlP1G+xkNWlHf+rBgjdccCq3EOeW0RPMWBY2LI2bITA0hA==;3:h0lIWvt1Uh2z8Pz3Dl60v2aEJaPeRsLaO47Ihp1KW1StZKqIGcWKjIlnXhnnrTBV+WBiZBv4JgGHMFpaqDwf/DAnMC/E4S/JisINZe6e6wG5MfVsfVR304xJ35yGtTb8yqA0e+vMZxAR9Q0BWf8ofA==;25:nkXKbrJKy/ss+8r6PhIudWBdGpPxOEzcqDCNZfY14Whf/lCnusTlmGwyMtwXzQ5DuhueSP7KKwFFOYFT1hA9Kkc3fFZWxGMUod9YzSj25Wn60moXN6eU5BrGnMaz7jdxMFDyjVsQYVoAP+/N2e4rQp/u+7tqm5+mjO3Ql0SBp6Bm84ZNOz8whURvgqFXK7IxRAVLMzVycfMiCdKlxq0YfLHlKfcWVz3jyRkux5jQMDCyyw/aOH/N4M+jjn3n66x5nGBr3SmvRRygcS2EdcjOOIuGuh5gx56DyjTO4pVjF/j2+t4PXor0nYafV2zWr9Wpxo4x2sk4cL/S81itQanQACeU8jjzfoxu3cxorobbQ52czd26gNZCrWywn+X3vkCg+i/fxb9EDRLdQdcjkvvlzjzE9x0Rq13crJDt2aGysmtN82Y+bCrX8siCx4mPKvdJ X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1189; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;31:fKhPKWN0IE90LT9KGFJTqIubB7AvfrE6oqjLH74Ab/WoYnnlnIwPdAMX5Aq0tXZrslw1yLMCok50GiKH+xz7BlVm8voEGS7hbqNGTJkUKA+BoOMg3LlC2RQm+02eoXPqXGSfz5gd5lrnP6BDwfjNEoPKgt49DSdpinvdfOi0NQe5lQpTqv/ht4RVrGNrAUGeFSViZQERknAKJDWuaK4Ov32oMphihTFG4Gyi3WtjiF0XsnxHkbOBxlqMUAzNx8hW;20:g3nv9U7ctbn4h2fKIKCVIK+yTxdJYufASPscdek3FWXXdy2AOSG/zUC94bp6VWyzQWN+IUMY/SogtWFHYA5SdOZhTzs5BS5Dsg+87kHgInLvXJvtE0/YU9eBsqf5t3kl97YaUpaCZjwHycEikInYAPcYV7g9kGQS63FNFmn91X4=;4:uTZ5ltlxvEnsV+4laZxuBXf2j2/LhbDfe/xxp4dFvf/1bmXFclYqjtlsoHM9vome/P/w6We+ifr0Xo4NwofBNyHfZS7+SYM3yLPFBOTbL8dAXQ5o9rx/GcBOc1IbEPa3J8sLdSc5Y2DkXO7VXr2sJSd868rWqc09EQI9ioW3pg+xy9v0Kb0vBS5Q/P3XKSiuSXlRz6AHdoU7DOoMckuFYW1LS1SC8XnqKqNrPl9ZEw7F5pTbSC6f76tBRWdYJYKzsDRe7Gb1xHbnoIbOVKcAAWdIsHY8e3P7whtCLJ5VnDMkS0ea4QFwbU0TEA1FrYlNsgdBRw0SUCxWbstL+juOFpmbktkflN9HBYh1j4ktjSpjxL+DGdugq2e+/D4+wDA6WeQzoO2aJpwwpvHKQf7ZyA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:CY4PR15MB1189;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1189; X-Forefront-PRVS: 011579F31F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(199003)(24454002)(189002)(377454003)(189998001)(97736004)(2950100002)(23746002)(6916009)(64126003)(7736002)(50466002)(4001350100001)(7846002)(65826007)(5660300001)(8676002)(81156014)(81166006)(3846002)(6116002)(558084003)(110136003)(586003)(83506001)(36756003)(31696002)(86362001)(50986999)(54356999)(76176999)(230700001)(31686004)(65806001)(66066001)(6666003)(42186005)(4326007)(101416001)(65956001)(2906002)(117156001)(92566002)(47776003)(33646002)(305945005)(68736007)(105586002)(106356001)(77096005)(15760500001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1189;H:[192.168.6.194];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR15MB1189;23:14Jz4fjCEJ4yvPHfy33LlCfa0T74c00MKuVxX?= =?Windows-1252?Q?7tjOgcVm13nwBR/d0ZC3iV090KtTzmRyRnUK6ok3Dl/CZtfBhzNDUXJW?= =?Windows-1252?Q?3gZpduzL45OeTrnF34V6y1thiyvaY1Dx0ZhvMLJY7GH5nvZ7FvNkLkLj?= =?Windows-1252?Q?2BBzTxZnURe0yPe19bjPMAlGIo+CeP5SowL0mx2hmiXwPG5m0I50IKSZ?= =?Windows-1252?Q?rGXzwH8+HMoBb6tZJaiHLHq/qW25kpTMGrnSqw54L2sGrAhOMLAVlyY5?= =?Windows-1252?Q?J3CNdwa7+beXYhiYzpFmNYIZMN2RjCMFmlIM8ZjAnreh0rcWL+oyqyhg?= =?Windows-1252?Q?MfdJVXhMlJ99hiYFlTsZ+x96cLU30Pz1Qs4/yQ5xgjP4drd6stlP8tja?= =?Windows-1252?Q?em6LDN0bLTHXUfejiNpFzSUF2XxVJNxjtXTzFJ4YzjGsYm7UW2Fgd2yv?= =?Windows-1252?Q?A8SlSQwNcHyB1dz2aTlSf6vL4Cjya4sEINsjv3Oxz73Y5soXWbXI1gzk?= =?Windows-1252?Q?521M7KztDU2OAosBT+QnIV94I3uPcjdM/zquCmpL3TDX9cLESgnM7YkX?= =?Windows-1252?Q?STkmMkLa1YfRzSZ3RQd7B6tPNG37P8wUVHpD68rTnDyK6unobE6Qep/x?= =?Windows-1252?Q?vsEoBKL11XP49slUvdW0Mu75EoSbxw7or3phhsGWnP6ixdDh8UqDw5Dh?= =?Windows-1252?Q?/Zgzg+LDPVG2SwYJCGVQpo3NDsKp6IfPqIl+SVmOK3nHwNQQodosoadH?= =?Windows-1252?Q?zQoeLBFqdxvQ7ZqouWS9gqqYbi6BYavQm7VWC1D39kYgpBgJGijrfVEW?= =?Windows-1252?Q?YJVV72MWAcyIaybfcHuFGY42Tl3q7nn5EdGoEddLCYKzzwumV/SFGrPM?= =?Windows-1252?Q?bPjLlcp+kGAcT1G0hrXy2PEbRQPYZ18jnfmfkPbdB1Cr4sjnebkUFdFr?= =?Windows-1252?Q?jWetHbkdUUlCYq8jzRZSZQlcaxLQWDY+j0Q9j9gbmsZZbzvjW6GHiCq6?= =?Windows-1252?Q?k1Wy5bmXQSeZaLpdwqLWRDN5P5n3zDeq6EUAxnFHAuXhQZTZsNx80jqp?= =?Windows-1252?Q?0GNycGc0Yvg6IyeRuWtHgypcXR9aqZugBhBF+zwpGrtEhEtCN4aZutv4?= =?Windows-1252?Q?QeAE97guxNbkSqePkKC2/5hmzYzvUGQypx4qy4bxO6M5RbQtatfXhb5R?= =?Windows-1252?Q?QC5sg+scqI7+v9LpMqi0lF1e7G/bcxZn2xzPZPbTKfu3HfMGmdI7V3Wo?= =?Windows-1252?Q?CGvpqKc5y2+y8ZWPdZ+KVcDEgXZqkWIGS8kbSWTbyZ19LYHeZ1YhpCTt?= =?Windows-1252?Q?mnLzuvrBwEsJ8ZdQthqKIKuS07i3sZB7YKBkDWbxUskMZZfaSuC6LKi+?= =?Windows-1252?Q?dJM8d8yzsrv6m2N5NYsoLkL716sA/3SZ88TwQ51rw1CEQJeJzrPaSaVm?= =?Windows-1252?Q?1ZVAadbZR3p9OWcG5BR8qYHH+ed8Eu54KWRU9Kdfw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;6:L85bv8qKKLDuYz4QjGhsz/tJQ3ltmuw/NL0JSrVjOW2O0l44DIzwAQE6VX5BZGjOCz0UE5zCuE9dpB8TB3IQqyqGN2sIsAAk88Y2VN6JWOr6MZ/UP4Fyno8MeigjqZOoWkruQiF8E307AQqtIPMcN8FcvzELj8tigLvQlh7ACdqQqYzmO3ZqqhjBQFY5/NiRFX70nLxJtnaOlwjIkWqMgycTSiEj3trzx5Dma0mWMvf0wIYmAXz7vFReZUBj9hxqvcjmwH8hjfpj7dN1QM5imj090ioPDUSeBiPgAzqcJvsWv7R1iuOwZ/lzaigzP7g1;5:j8aAI5Qa1QSR9BXDEuSChm/vMFPeAMxv8cqx4xjXSE5HzBSPC/1mPnsoRYxrZFIsLIW9bVqvTJtM9Kv06qkMwbfiLu7JExdR9Cb55jQj1xVHYAqwIlGuKc0AbbXiNwNm0qAbsHfqbrMQxafWVLqNyOeh9izPBQCZ/pJsI6G5r3s=;24:q0tEw2FLnbQ2+Q+slJGcO9urwjTxw9TuqmrSRZosTepqfpa//nFPx3oFeiOXuuI1h0TqLRePsWS3a2nPLzOXtBW68AFHuLkp3e1uyMI9gj8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;7:qi5qGxH24oExEXPjTtyTFgW3oqcw8JoIcy3RrZ/49srCl/5Lj3A8I/eOZrVhHx/t7GnHesSSqWvGRYTx5mgppWKnyxe2dbep10mnGBEIsM8LZxVWgliX2Vs4WmKjJJYK/zkeKyybFtmyOH+y/+qUSoiuojpXRwp7LisDxB8aJguo2aAAFezqHePQLggkz4pKo2dZP/rT835vcTcmC2f8eS2QoN+I7M/btuhbK9dYZO4fHPnB9v0q9oGAFfD6d0Fu0ezAbk64TJkRoq151JUE66bu0JGlSNH0VWVl5BBrn0xAO93KifE4ep/8mTrUo4G6enWA87yPLTMGNMi1bKwEXVsP70RBZevy66GIlYj7iec=;20:GlH3ERBuL8CC0PBStl532vCeVI7mDo5PnRsYhf512K030zFJaBWhQlt3VlmyjZbxywfBymFKjVcPpiC8zs7DC1TH8YMUuFYPXYecopstQ1i3pj9Oo8r+59FZ0rQCwCcHqI7aeHuoFz9H4mLEIU9ArSa59jn5AaQu+HAtti46AOk= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2016 13:57:04.3120 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1189 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-03_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 182 Lines: 8 On 11/03/2016 03:38 AM, Johannes Thumshirn wrote: > bsg_validate_sgv4_hdr() doesn't care about the request_queue, so drop it > from it's arguments. Thanks, applied. -- Jens Axboe