Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758298AbcKCP4M (ORCPT ); Thu, 3 Nov 2016 11:56:12 -0400 Received: from gloria.sntech.de ([95.129.55.99]:47704 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754769AbcKCP4K (ORCPT ); Thu, 3 Nov 2016 11:56:10 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Andy Yan Cc: david.wu@rock-chips.com, linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] pinctrl: rockchip: add support for rk1108 Date: Thu, 03 Nov 2016 16:55:45 +0100 Message-ID: <3450255.c5nv6dGt3I@diego> User-Agent: KMail/4.14.10 (Linux/4.6.0-1-amd64; KDE/4.14.22; x86_64; ; ) In-Reply-To: <1478176470-11956-1-git-send-email-andy.yan@rock-chips.com> References: <1478175975-11779-1-git-send-email-andy.yan@rock-chips.com> <1478176470-11956-1-git-send-email-andy.yan@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1110 Lines: 37 Am Donnerstag, 3. November 2016, 20:34:30 schrieb Andy Yan: > Add basic support for rk1108 soc > > Signed-off-by: Andy Yan nice when support for a new soc is that easy in a driver :-) There are two small issues below and with those fixed Reviewed-by: Heiko Stuebner > --- > > drivers/pinctrl/pinctrl-rockchip.c | 27 ++++++++++++++++++++++++++- > 1 file changed, 26 insertions(+), 1 deletion(-) missing devicetree binding update for the new compatible > diff --git a/drivers/pinctrl/pinctrl-rockchip.c > b/drivers/pinctrl/pinctrl-rockchip.c index 49bf7dc..9f324b1 100644 > --- a/drivers/pinctrl/pinctrl-rockchip.c > +++ b/drivers/pinctrl/pinctrl-rockchip.c [...] > +static struct rockchip_pin_ctrl rk1108_pin_ctrl = { > + .pin_banks = rk1108_pin_banks, > + .nr_banks = ARRAY_SIZE(rk1108_pin_banks), > + .label = "RK1108-GPIO", > + .type = RK1108, > + .grf_mux_offset = 0x10, > + .pmu_mux_offset = 0x0, > + .pull_calc_reg = rk3288_calc_pull_reg_and_bit, this last line has spaces instead of tabs between .pull_calc_reg and the "=" Heiko